summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2021-02-15 13:08:19 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-02-24 10:00:02 +0000
commit32b99169a56aa18047039092856a744d0e3d2d67 (patch)
tree169861274cf4c167e041616455c649dd52f7175b /src/mainboard
parent2c7842407af8e84b28d41e8369ccf199748f65ce (diff)
downloadcoreboot-32b99169a56aa18047039092856a744d0e3d2d67.tar.xz
mb/amd,google/zork: Move init_tables() call
The semantics of pirq_setup() from previous platforms was to only setup the global pointers for PIC and APIC tables, not to create or modify the tables themselves. Change-Id: Iaa7c31eed21432dc2b3fe6b32803bd2658fd5e2d Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/50717 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/amd/bilby/mainboard.c2
-rw-r--r--src/mainboard/amd/majolica/mainboard.c2
-rw-r--r--src/mainboard/amd/mandolin/mainboard.c2
-rw-r--r--src/mainboard/google/zork/mainboard.c2
4 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/amd/bilby/mainboard.c b/src/mainboard/amd/bilby/mainboard.c
index 97acf6c97a..2bfdb59fa3 100644
--- a/src/mainboard/amd/bilby/mainboard.c
+++ b/src/mainboard/amd/bilby/mainboard.c
@@ -75,7 +75,6 @@ static void init_tables(void)
static void pirq_setup(void)
{
- init_tables();
intr_data_ptr = fch_apic_routing;
picr_data_ptr = fch_pic_routing;
}
@@ -100,6 +99,7 @@ static void bilby_enable(struct device *dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ init_tables();
/* Initialize the PIRQ data structures for consumption */
pirq_setup();
}
diff --git a/src/mainboard/amd/majolica/mainboard.c b/src/mainboard/amd/majolica/mainboard.c
index cbb1145a69..bba6a5fefb 100644
--- a/src/mainboard/amd/majolica/mainboard.c
+++ b/src/mainboard/amd/majolica/mainboard.c
@@ -81,7 +81,6 @@ static void init_tables(void)
static void pirq_setup(void)
{
- init_tables();
intr_data_ptr = fch_apic_routing;
picr_data_ptr = fch_pic_routing;
}
@@ -94,6 +93,7 @@ static void majolica_enable(struct device *dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ init_tables();
/* Initialize the PIRQ data structures for consumption */
pirq_setup();
}
diff --git a/src/mainboard/amd/mandolin/mainboard.c b/src/mainboard/amd/mandolin/mainboard.c
index 0d208da348..3513f614fe 100644
--- a/src/mainboard/amd/mandolin/mainboard.c
+++ b/src/mainboard/amd/mandolin/mainboard.c
@@ -75,7 +75,6 @@ static void init_tables(void)
static void pirq_setup(void)
{
- init_tables();
intr_data_ptr = fch_apic_routing;
picr_data_ptr = fch_pic_routing;
}
@@ -100,6 +99,7 @@ static void mandolin_enable(struct device *dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ init_tables();
/* Initialize the PIRQ data structures for consumption */
pirq_setup();
}
diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c
index 1558245773..06f4e8dda1 100644
--- a/src/mainboard/google/zork/mainboard.c
+++ b/src/mainboard/google/zork/mainboard.c
@@ -104,7 +104,6 @@ static void init_tables(void)
/* PIRQ Setup */
static void pirq_setup(void)
{
- init_tables();
intr_data_ptr = fch_apic_routing;
picr_data_ptr = fch_pic_routing;
}
@@ -202,6 +201,7 @@ static void zork_enable(struct device *dev)
{
printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
+ init_tables();
/* Initialize the PIRQ data structures for consumption */
pirq_setup();