summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-03-19 15:13:46 +0100
committerPatrick Georgi <pgeorgi@google.com>2021-03-22 11:26:22 +0000
commit88f94a9635cd64aaf6eeb3ed3991dceabcf6387a (patch)
treefef34198fe0464e964e985d4889f9df747bd66b9 /src/mainboard
parentd12d24b03930665be9ed9a16875577a770e6d7db (diff)
downloadcoreboot-88f94a9635cd64aaf6eeb3ed3991dceabcf6387a.tar.xz
lynxpoint/broadwell: Rename LP GPIO config global
Do not use the same name as the non-LP GPIO config. This allows checking at build-time that a mainboard uses the correct GPIO config format. Without this commit, there are no build-time errors when using the wrong format of GPIO config, but there would be undefined behavior at runtime. Tested by trying to build asrock/b85m_pro4 and hp/folio_9480m after toggling the `INTEL_LYNXPOINT_LP` Kconfig option (and trimming down the USB config arrays for asrock/b85m_pro4). In both cases, building failed because the necessary GPIO config global is not defined, as expected. Change-Id: Ib06507ef8179da22bdb27593daf972e788051f3a Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51661 Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/auron/variants/auron_paine/gpio.c2
-rw-r--r--src/mainboard/google/auron/variants/auron_yuna/gpio.c2
-rw-r--r--src/mainboard/google/auron/variants/buddy/gpio.c2
-rw-r--r--src/mainboard/google/auron/variants/gandof/gpio.c2
-rw-r--r--src/mainboard/google/auron/variants/lulu/gpio.c2
-rw-r--r--src/mainboard/google/auron/variants/samus/gpio.c2
-rw-r--r--src/mainboard/google/beltino/variants/mccloud/gpio.c2
-rw-r--r--src/mainboard/google/beltino/variants/monroe/gpio.c2
-rw-r--r--src/mainboard/google/beltino/variants/panther/gpio.c2
-rw-r--r--src/mainboard/google/beltino/variants/tricky/gpio.c2
-rw-r--r--src/mainboard/google/beltino/variants/zako/gpio.c2
-rw-r--r--src/mainboard/google/jecht/variants/guado/gpio.c2
-rw-r--r--src/mainboard/google/jecht/variants/jecht/gpio.c2
-rw-r--r--src/mainboard/google/jecht/variants/rikku/gpio.c2
-rw-r--r--src/mainboard/google/jecht/variants/tidus/gpio.c2
-rw-r--r--src/mainboard/google/slippy/variants/falco/gpio.c2
-rw-r--r--src/mainboard/google/slippy/variants/leon/gpio.c2
-rw-r--r--src/mainboard/google/slippy/variants/peppy/gpio.c2
-rw-r--r--src/mainboard/google/slippy/variants/wolf/gpio.c2
-rw-r--r--src/mainboard/hp/folio_9480m/gpio.c2
-rw-r--r--src/mainboard/intel/wtm2/gpio.c2
-rw-r--r--src/mainboard/purism/librem_bdw/gpio.c2
22 files changed, 22 insertions, 22 deletions
diff --git a/src/mainboard/google/auron/variants/auron_paine/gpio.c b/src/mainboard/google/auron/variants/auron_paine/gpio.c
index fb9ab95130..2ed92cdb81 100644
--- a/src/mainboard/google/auron/variants/auron_paine/gpio.c
+++ b/src/mainboard/google/auron/variants/auron_paine/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/auron/variants/auron_yuna/gpio.c b/src/mainboard/google/auron/variants/auron_yuna/gpio.c
index fb9ab95130..2ed92cdb81 100644
--- a/src/mainboard/google/auron/variants/auron_yuna/gpio.c
+++ b/src/mainboard/google/auron/variants/auron_yuna/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/auron/variants/buddy/gpio.c b/src/mainboard/google/auron/variants/buddy/gpio.c
index 826b1bd444..0e27f97e57 100644
--- a/src/mainboard/google/auron/variants/buddy/gpio.c
+++ b/src/mainboard/google/auron/variants/buddy/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/auron/variants/gandof/gpio.c b/src/mainboard/google/auron/variants/gandof/gpio.c
index 0333d806a6..4d6592bbae 100644
--- a/src/mainboard/google/auron/variants/gandof/gpio.c
+++ b/src/mainboard/google/auron/variants/gandof/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/auron/variants/lulu/gpio.c b/src/mainboard/google/auron/variants/lulu/gpio.c
index a8378a1cc2..eccf34bc23 100644
--- a/src/mainboard/google/auron/variants/lulu/gpio.c
+++ b/src/mainboard/google/auron/variants/lulu/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/auron/variants/samus/gpio.c b/src/mainboard/google/auron/variants/samus/gpio.c
index 3c1f4c50cf..f1b551017c 100644
--- a/src/mainboard/google/auron/variants/samus/gpio.c
+++ b/src/mainboard/google/auron/variants/samus/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/beltino/variants/mccloud/gpio.c b/src/mainboard/google/beltino/variants/mccloud/gpio.c
index 91e808dd41..0f377acb7c 100644
--- a/src/mainboard/google/beltino/variants/mccloud/gpio.c
+++ b/src/mainboard/google/beltino/variants/mccloud/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/beltino/variants/monroe/gpio.c b/src/mainboard/google/beltino/variants/monroe/gpio.c
index 4aead217df..b2af4cd2bb 100644
--- a/src/mainboard/google/beltino/variants/monroe/gpio.c
+++ b/src/mainboard/google/beltino/variants/monroe/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/beltino/variants/panther/gpio.c b/src/mainboard/google/beltino/variants/panther/gpio.c
index 19e44e2ab1..438b771447 100644
--- a/src/mainboard/google/beltino/variants/panther/gpio.c
+++ b/src/mainboard/google/beltino/variants/panther/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/beltino/variants/tricky/gpio.c b/src/mainboard/google/beltino/variants/tricky/gpio.c
index 809a4486ab..05394cd3b4 100644
--- a/src/mainboard/google/beltino/variants/tricky/gpio.c
+++ b/src/mainboard/google/beltino/variants/tricky/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/beltino/variants/zako/gpio.c b/src/mainboard/google/beltino/variants/zako/gpio.c
index 15cb0c0c33..8f2e372386 100644
--- a/src/mainboard/google/beltino/variants/zako/gpio.c
+++ b/src/mainboard/google/beltino/variants/zako/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/jecht/variants/guado/gpio.c b/src/mainboard/google/jecht/variants/guado/gpio.c
index 91e808dd41..0f377acb7c 100644
--- a/src/mainboard/google/jecht/variants/guado/gpio.c
+++ b/src/mainboard/google/jecht/variants/guado/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/jecht/variants/jecht/gpio.c b/src/mainboard/google/jecht/variants/jecht/gpio.c
index 19e44e2ab1..438b771447 100644
--- a/src/mainboard/google/jecht/variants/jecht/gpio.c
+++ b/src/mainboard/google/jecht/variants/jecht/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/jecht/variants/rikku/gpio.c b/src/mainboard/google/jecht/variants/rikku/gpio.c
index 91e808dd41..0f377acb7c 100644
--- a/src/mainboard/google/jecht/variants/rikku/gpio.c
+++ b/src/mainboard/google/jecht/variants/rikku/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/jecht/variants/tidus/gpio.c b/src/mainboard/google/jecht/variants/tidus/gpio.c
index a53b97ae96..abba4d99f8 100644
--- a/src/mainboard/google/jecht/variants/tidus/gpio.c
+++ b/src/mainboard/google/jecht/variants/tidus/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/slippy/variants/falco/gpio.c b/src/mainboard/google/slippy/variants/falco/gpio.c
index 86efbb8a45..b0d50a2a83 100644
--- a/src/mainboard/google/slippy/variants/falco/gpio.c
+++ b/src/mainboard/google/slippy/variants/falco/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/slippy/variants/leon/gpio.c b/src/mainboard/google/slippy/variants/leon/gpio.c
index 63babd6399..7964ef3527 100644
--- a/src/mainboard/google/slippy/variants/leon/gpio.c
+++ b/src/mainboard/google/slippy/variants/leon/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/slippy/variants/peppy/gpio.c b/src/mainboard/google/slippy/variants/peppy/gpio.c
index fb9ab95130..2ed92cdb81 100644
--- a/src/mainboard/google/slippy/variants/peppy/gpio.c
+++ b/src/mainboard/google/slippy/variants/peppy/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/google/slippy/variants/wolf/gpio.c b/src/mainboard/google/slippy/variants/wolf/gpio.c
index 9be9077777..0031f585ad 100644
--- a/src/mainboard/google/slippy/variants/wolf/gpio.c
+++ b/src/mainboard/google/slippy/variants/wolf/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_UNUSED, /* 0: UNUSED */
LP_GPIO_UNUSED, /* 1: UNUSED */
LP_GPIO_UNUSED, /* 2: UNUSED */
diff --git a/src/mainboard/hp/folio_9480m/gpio.c b/src/mainboard/hp/folio_9480m/gpio.c
index cb32f4f733..016ac76c59 100644
--- a/src/mainboard/hp/folio_9480m/gpio.c
+++ b/src/mainboard/hp/folio_9480m/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
[0] = { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_IRQ_LEVEL },
[1] = { .conf0 = GPIO_MODE_GPIO | GPIO_DIR_INPUT | GPIO_INVERT | GPIO_IRQ_LEVEL },
[2] = LP_GPIO_OUT_LOW,
diff --git a/src/mainboard/intel/wtm2/gpio.c b/src/mainboard/intel/wtm2/gpio.c
index 9b087a1e02..ce8a5da98d 100644
--- a/src/mainboard/intel/wtm2/gpio.c
+++ b/src/mainboard/intel/wtm2/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
LP_GPIO_NATIVE, /* 0: LPSS_UART1_RXD */
LP_GPIO_NATIVE, /* 1: LPSS_UART1_TXD */
LP_GPIO_NATIVE, /* 2: LPSS_UART1_RTS_N_R */
diff --git a/src/mainboard/purism/librem_bdw/gpio.c b/src/mainboard/purism/librem_bdw/gpio.c
index d2994aede9..dcb6cc6bc9 100644
--- a/src/mainboard/purism/librem_bdw/gpio.c
+++ b/src/mainboard/purism/librem_bdw/gpio.c
@@ -2,7 +2,7 @@
#include <southbridge/intel/lynxpoint/lp_gpio.h>
-const struct pch_lp_gpio_map mainboard_gpio_map[] = {
+const struct pch_lp_gpio_map mainboard_lp_gpio_map[] = {
[0] = LP_GPIO_INPUT,
[1] = LP_GPIO_INPUT,
[2] = LP_GPIO_INPUT,