summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2020-01-25 17:51:46 +0100
committerPatrick Georgi <pgeorgi@google.com>2020-02-09 19:31:55 +0000
commit1c40cdf36089f95934b87907ced627a6bcab3700 (patch)
tree6eb829c5e29bff9cddabbac1e8db2c77436d1d5e /src/mainboard
parente7ad0f2a2a29f3807a66eccaa9c7962fea358bf3 (diff)
downloadcoreboot-1c40cdf36089f95934b87907ced627a6bcab3700.tar.xz
mb/lenovo/t400: Move `gma-mainboard.ads` to variants
Some board revisions have the straps for display port detection wrongly configured. So with a single list covering all variants' possible outputs, we make libgfxinit probe unimplemented ports which may stall the GMBUS controller and delay the boot for some hundred milliseconds. This just copies the list to the various variants with different display ports, so we can test the actual changes individually. Change-Id: I48cdea1d71d9553b6bdbce432eae986996329239 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38571 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/lenovo/t400/Makefile.inc8
-rw-r--r--src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads (renamed from src/mainboard/lenovo/t400/gma-mainboard.ads)0
-rw-r--r--src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads31
-rw-r--r--src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads31
4 files changed, 69 insertions, 1 deletions
diff --git a/src/mainboard/lenovo/t400/Makefile.inc b/src/mainboard/lenovo/t400/Makefile.inc
index e4e6a1f012..5d5669e2a3 100644
--- a/src/mainboard/lenovo/t400/Makefile.inc
+++ b/src/mainboard/lenovo/t400/Makefile.inc
@@ -22,4 +22,10 @@ ramstage-y += dock.c
ramstage-y += cstates.c
ramstage-y += blc.c
-ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads
+ifeq ($(CONFIG_MAINBOARD_USE_LIBGFXINIT),y)
+ramstage-$(CONFIG_BOARD_LENOVO_T400) += variants/t400/malibu-3/gma-mainboard.ads
+ramstage-$(CONFIG_BOARD_LENOVO_R400) += variants/t400/malibu-3/gma-mainboard.ads
+ramstage-$(CONFIG_BOARD_LENOVO_T500) += variants/t400/coronado-5/gma-mainboard.ads
+ramstage-$(CONFIG_BOARD_LENOVO_W500) += variants/t400/coronado-5/gma-mainboard.ads
+ramstage-$(CONFIG_BOARD_LENOVO_R500) += variants/r500/gma-mainboard.ads
+endif
diff --git a/src/mainboard/lenovo/t400/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads
index 680dd1b0aa..680dd1b0aa 100644
--- a/src/mainboard/lenovo/t400/gma-mainboard.ads
+++ b/src/mainboard/lenovo/t400/variants/r500/gma-mainboard.ads
diff --git a/src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads
new file mode 100644
index 0000000000..680dd1b0aa
--- /dev/null
+++ b/src/mainboard/lenovo/t400/variants/t400/coronado-5/gma-mainboard.ads
@@ -0,0 +1,31 @@
+--
+-- This file is part of the coreboot project.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+ ports : constant Port_List :=
+ (DP1,
+ HDMI1,
+ HDMI2,
+ Analog,
+ Internal,
+ others => Disabled);
+
+end GMA.Mainboard;
diff --git a/src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads b/src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads
new file mode 100644
index 0000000000..680dd1b0aa
--- /dev/null
+++ b/src/mainboard/lenovo/t400/variants/t400/malibu-3/gma-mainboard.ads
@@ -0,0 +1,31 @@
+--
+-- This file is part of the coreboot project.
+--
+-- This program is free software; you can redistribute it and/or modify
+-- it under the terms of the GNU General Public License as published by
+-- the Free Software Foundation; either version 2 of the License, or
+-- (at your option) any later version.
+--
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+-- GNU General Public License for more details.
+--
+
+with HW.GFX.GMA;
+with HW.GFX.GMA.Display_Probing;
+
+use HW.GFX.GMA;
+use HW.GFX.GMA.Display_Probing;
+
+private package GMA.Mainboard is
+
+ ports : constant Port_List :=
+ (DP1,
+ HDMI1,
+ HDMI2,
+ Analog,
+ Internal,
+ others => Disabled);
+
+end GMA.Mainboard;