summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorArthur Heymans <arthur@aheymans.xyz>2019-05-12 15:25:54 +0200
committerNico Huber <nico.h@gmx.de>2019-05-14 23:22:26 +0000
commit325865db5683f32d846cc452504da00ec8d53710 (patch)
tree8522419c7e18c17c8a73462ceda33eed45100c12 /src/mainboard
parentcadc70f7974db25144381b3ea26d4b660233f4dd (diff)
downloadcoreboot-325865db5683f32d846cc452504da00ec8d53710.tar.xz
soc/intel/broadwell: Don't use a pointer for pei_data
To improve the bootflow, the scope of the pei_data needs to be extended. Change-Id: Ic6d91692a7bf9218b81da5bb36b5b26dabac454e Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32762 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/auron/romstage.c8
-rw-r--r--src/mainboard/google/jecht/romstage.c8
-rw-r--r--src/mainboard/intel/wtm2/romstage.c6
-rw-r--r--src/mainboard/purism/librem_bdw/romstage.c6
4 files changed, 6 insertions, 22 deletions
diff --git a/src/mainboard/google/auron/romstage.c b/src/mainboard/google/auron/romstage.c
index 5e1a66ac24..497489911e 100644
--- a/src/mainboard/google/auron/romstage.c
+++ b/src/mainboard/google/auron/romstage.c
@@ -29,15 +29,11 @@ __weak void variant_romstage_entry(struct romstage_params *rp)
void mainboard_romstage_entry(struct romstage_params *rp)
{
- struct pei_data pei_data;
-
post_code(0x32);
/* Fill out PEI DATA */
- memset(&pei_data, 0, sizeof(pei_data));
- mainboard_fill_pei_data(&pei_data);
- mainboard_fill_spd_data(&pei_data);
- rp->pei_data = &pei_data;
+ mainboard_fill_pei_data(&rp->pei_data);
+ mainboard_fill_spd_data(&rp->pei_data);
/* Call into the real romstage main with this board's attributes. */
romstage_common(rp);
diff --git a/src/mainboard/google/jecht/romstage.c b/src/mainboard/google/jecht/romstage.c
index de0ed30575..8d1ae8aca2 100644
--- a/src/mainboard/google/jecht/romstage.c
+++ b/src/mainboard/google/jecht/romstage.c
@@ -29,15 +29,11 @@
void mainboard_romstage_entry(struct romstage_params *rp)
{
- struct pei_data pei_data;
-
post_code(0x32);
/* Fill out PEI DATA */
- memset(&pei_data, 0, sizeof(pei_data));
- mainboard_fill_pei_data(&pei_data);
- mainboard_fill_spd_data(&pei_data);
- rp->pei_data = &pei_data;
+ mainboard_fill_pei_data(&rp->pei_data);
+ mainboard_fill_spd_data(&rp->pei_data);
/* Call into the real romstage main with this board's attributes. */
romstage_common(rp);
diff --git a/src/mainboard/intel/wtm2/romstage.c b/src/mainboard/intel/wtm2/romstage.c
index de4237d222..5b8df275d8 100644
--- a/src/mainboard/intel/wtm2/romstage.c
+++ b/src/mainboard/intel/wtm2/romstage.c
@@ -24,14 +24,10 @@
void mainboard_romstage_entry(struct romstage_params *rp)
{
- struct pei_data pei_data;
-
post_code(0x32);
/* Fill out PEI DATA */
- memset(&pei_data, 0, sizeof(pei_data));
- mainboard_fill_pei_data(&pei_data);
- rp->pei_data = &pei_data;
+ mainboard_fill_pei_data(&rp->pei_data);
romstage_common(rp);
}
diff --git a/src/mainboard/purism/librem_bdw/romstage.c b/src/mainboard/purism/librem_bdw/romstage.c
index 6591229621..5330d191b4 100644
--- a/src/mainboard/purism/librem_bdw/romstage.c
+++ b/src/mainboard/purism/librem_bdw/romstage.c
@@ -20,12 +20,8 @@
void mainboard_romstage_entry(struct romstage_params *rp)
{
- struct pei_data pei_data;
-
/* Fill out PEI DATA */
- memset(&pei_data, 0, sizeof(pei_data));
- mainboard_fill_pei_data(&pei_data);
- rp->pei_data = &pei_data;
+ mainboard_fill_pei_data(&rp->pei_data);
/* Initialize memory */
romstage_common(rp);