diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2015-10-17 13:16:27 +0200 |
|---|---|---|
| committer | David Hendricks <dhendrix@chromium.org> | 2015-10-23 20:44:06 +0200 |
| commit | 421b47e05059d3dbcd2ed06be60f574fdbe69b15 (patch) | |
| tree | de05b7dc91727d5091111fcedd6b1c699b166258 /src/mainboard | |
| parent | 907ea331f2b2769331982fc373f55c5c86146c4b (diff) | |
| download | coreboot-421b47e05059d3dbcd2ed06be60f574fdbe69b15.tar.xz | |
SB800-mainboards: use write8 to disable unused GPP CLK
don't use non-volatile pointers for MMIO access
Change-Id: I9f38012a806e43f2535265f1d25537c59b53904e
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: http://review.coreboot.org/12081
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/amd/persimmon/mainboard.c | 10 | ||||
| -rw-r--r-- | src/mainboard/gizmosphere/gizmo/mainboard.c | 10 | ||||
| -rw-r--r-- | src/mainboard/jetway/nf81-t56n-lf/mainboard.c | 10 | ||||
| -rw-r--r-- | src/mainboard/lippert/frontrunner-af/mainboard.c | 10 | ||||
| -rw-r--r-- | src/mainboard/lippert/toucan-af/mainboard.c | 10 |
5 files changed, 25 insertions, 25 deletions
diff --git a/src/mainboard/amd/persimmon/mainboard.c b/src/mainboard/amd/persimmon/mainboard.c index ae18a37d4e..a9cdab3240 100644 --- a/src/mainboard/amd/persimmon/mainboard.c +++ b/src/mainboard/amd/persimmon/mainboard.c @@ -158,11 +158,11 @@ static void mainboard_enable(device_t dev) /* enable GPP CLK0 thru CLK1 */ /* disable GPP CLK2 thru SLT_GFX_CLK */ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE); - *(misc_mem_clk_cntrl + 0) = 0xFF; - *(misc_mem_clk_cntrl + 1) = 0x00; - *(misc_mem_clk_cntrl + 2) = 0x00; - *(misc_mem_clk_cntrl + 3) = 0x00; - *(misc_mem_clk_cntrl + 4) = 0x00; + write8(misc_mem_clk_cntrl + 0, 0xFF); + write8(misc_mem_clk_cntrl + 1, 0x00); + write8(misc_mem_clk_cntrl + 2, 0x00); + write8(misc_mem_clk_cntrl + 3, 0x00); + write8(misc_mem_clk_cntrl + 4, 0x00); /* * Initialize ASF registers to an arbitrary address because someone diff --git a/src/mainboard/gizmosphere/gizmo/mainboard.c b/src/mainboard/gizmosphere/gizmo/mainboard.c index 82de7527b6..d04a0aaca2 100644 --- a/src/mainboard/gizmosphere/gizmo/mainboard.c +++ b/src/mainboard/gizmosphere/gizmo/mainboard.c @@ -62,11 +62,11 @@ static void mainboard_enable(device_t dev) /* enable GPP CLK0 thru CLK1 */ /* disable GPP CLK2 thru SLT_GFX_CLK */ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE); - *(misc_mem_clk_cntrl + 0) = 0xFF; - *(misc_mem_clk_cntrl + 1) = 0x00; - *(misc_mem_clk_cntrl + 2) = 0x00; - *(misc_mem_clk_cntrl + 3) = 0x00; - *(misc_mem_clk_cntrl + 4) = 0x00; + write8(misc_mem_clk_cntrl + 0, 0xFF); + write8(misc_mem_clk_cntrl + 1, 0x00); + write8(misc_mem_clk_cntrl + 2, 0x00); + write8(misc_mem_clk_cntrl + 3, 0x00); + write8(misc_mem_clk_cntrl + 4, 0x00); /* * Force the onboard SATA port to GEN2 speed. diff --git a/src/mainboard/jetway/nf81-t56n-lf/mainboard.c b/src/mainboard/jetway/nf81-t56n-lf/mainboard.c index 9f6cf78181..e64fce00cc 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/mainboard.c +++ b/src/mainboard/jetway/nf81-t56n-lf/mainboard.c @@ -160,11 +160,11 @@ static void mainboard_enable(device_t dev) /* enable GPP CLK0 thru CLK3 (interleaved) */ /* disable GPP CLK4 thru SLT_GFX_CLK */ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE); - *(misc_mem_clk_cntrl + 0) = 0xFF; - *(misc_mem_clk_cntrl + 1) = 0xFF; - *(misc_mem_clk_cntrl + 2) = 0x00; - *(misc_mem_clk_cntrl + 3) = 0x00; - *(misc_mem_clk_cntrl + 4) = 0x00; + write8(misc_mem_clk_cntrl + 0, 0xFF); + write8(misc_mem_clk_cntrl + 1, 0xFF); + write8(misc_mem_clk_cntrl + 2, 0x00); + write8(misc_mem_clk_cntrl + 3, 0x00); + write8(misc_mem_clk_cntrl + 4, 0x00); /* * Initialize ASF registers to an arbitrary address because someone diff --git a/src/mainboard/lippert/frontrunner-af/mainboard.c b/src/mainboard/lippert/frontrunner-af/mainboard.c index 692e2a6836..6da340c0c1 100644 --- a/src/mainboard/lippert/frontrunner-af/mainboard.c +++ b/src/mainboard/lippert/frontrunner-af/mainboard.c @@ -171,11 +171,11 @@ static void mainboard_enable(device_t dev) /* enable GPP CLK0 */ /* disable GPP CLK1 thru SLT_GFX_CLK */ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE); - *(misc_mem_clk_cntrl + 0) = 0x0F; - *(misc_mem_clk_cntrl + 1) = 0x00; - *(misc_mem_clk_cntrl + 2) = 0x00; - *(misc_mem_clk_cntrl + 3) = 0x00; - *(misc_mem_clk_cntrl + 4) = 0x00; + write8(misc_mem_clk_cntrl + 0, 0x0F); + write8(misc_mem_clk_cntrl + 1, 0x00); + write8(misc_mem_clk_cntrl + 2, 0x00); + write8(misc_mem_clk_cntrl + 3, 0x00); + write8(misc_mem_clk_cntrl + 4, 0x00); /* * Initialize ASF registers to an arbitrary address because someone diff --git a/src/mainboard/lippert/toucan-af/mainboard.c b/src/mainboard/lippert/toucan-af/mainboard.c index 4afef231ea..ea62e24694 100644 --- a/src/mainboard/lippert/toucan-af/mainboard.c +++ b/src/mainboard/lippert/toucan-af/mainboard.c @@ -138,11 +138,11 @@ static void mainboard_enable(device_t dev) /* enable GPP CLK0 thru CLK1 */ /* disable GPP CLK2 thru SLT_GFX_CLK */ u8 *misc_mem_clk_cntrl = (u8 *)(ACPI_MMIO_BASE + MISC_BASE); - *(misc_mem_clk_cntrl + 0) = 0xFF; - *(misc_mem_clk_cntrl + 1) = 0x00; - *(misc_mem_clk_cntrl + 2) = 0x00; - *(misc_mem_clk_cntrl + 3) = 0x00; - *(misc_mem_clk_cntrl + 4) = 0x00; + write8(misc_mem_clk_cntrl + 0, 0xFF); + write8(misc_mem_clk_cntrl + 1, 0x00); + write8(misc_mem_clk_cntrl + 2, 0x00); + write8(misc_mem_clk_cntrl + 3, 0x00); + write8(misc_mem_clk_cntrl + 4, 0x00); /* * Initialize ASF registers to an arbitrary address because someone |