diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-09-01 06:13:08 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-09-06 22:23:19 +0000 |
| commit | 64df52e269d5ec2c04bd7b65381b21d6966326af (patch) | |
| tree | d33259218802b3197b964393c84958c1ec459705 /src/mainboard | |
| parent | 081b66951f04bb67ad2d04750212a45fc0c24e90 (diff) | |
| download | coreboot-64df52e269d5ec2c04bd7b65381b21d6966326af.tar.xz | |
AGESA f14: Work around soft-resets
Vendorcode expects some DRAM controller registers to
be writable, but they are actually locked after soft
resets if C6 states are enabled.
Without the workaround, raminit fails on soft resets.
Change-Id: I6b9e275e11b2907d026c13341334983a4d9c8889
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/21317
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/lippert/frontrunner-af/romstage.c | 12 | ||||
| -rw-r--r-- | src/mainboard/lippert/toucan-af/romstage.c | 12 |
2 files changed, 0 insertions, 24 deletions
diff --git a/src/mainboard/lippert/frontrunner-af/romstage.c b/src/mainboard/lippert/frontrunner-af/romstage.c index 8a54555841..195ce4665a 100644 --- a/src/mainboard/lippert/frontrunner-af/romstage.c +++ b/src/mainboard/lippert/frontrunner-af/romstage.c @@ -23,15 +23,3 @@ void board_BeforeAgesa(struct sysinfo *cb) { smscsuperio_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); } - -#if 0 - post_code(0x40); - /* Reboots with outb(3,0x92), outb(4,0xcf9) or triple-fault all - * hang, looks like DRAM re-init goes wrong, don't know why. */ - val = agesawrapper_amdinitpost(); - if (val == 7) /* fatal, amdinitenv below is going to hang */ - outb(0x06, 0x0cf9); /* reset system harder instead */ - - post_code(0x42); - agesawrapper_amdinitenv(); -#endif diff --git a/src/mainboard/lippert/toucan-af/romstage.c b/src/mainboard/lippert/toucan-af/romstage.c index 5128db0fa2..a3aea8d2d5 100644 --- a/src/mainboard/lippert/toucan-af/romstage.c +++ b/src/mainboard/lippert/toucan-af/romstage.c @@ -24,15 +24,3 @@ void board_BeforeAgesa(struct sysinfo *cb) { winbond_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); } - -#if 0 - post_code(0x40); - /* Reboots with outb(3,0x92), outb(4,0xcf9) or triple-fault all - * hang, looks like DRAM re-init goes wrong, don't know why. */ - val = agesawrapper_amdinitpost(); - if (val == 7) /* fatal, amdinitenv below is going to hang */ - outb(0x06, 0x0cf9); /* reset system harder instead */ - - post_code(0x42); - agesawrapper_amdinitenv(); -#endif |