summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@chromium.org>2018-01-26 10:40:09 -0800
committerFurquan Shaikh <furquan@google.com>2018-01-30 20:20:36 +0000
commitc96ad868d4ad869523b615d90fb0bea4bd6d4ef6 (patch)
tree76e5bdfdb499f702c86d7e72ad95fb2e852dae21 /src/mainboard
parentec91dd8feb16ea89d5a5d35b701bca09d1200afa (diff)
downloadcoreboot-c96ad868d4ad869523b615d90fb0bea4bd6d4ef6.tar.xz
chromeec: Decouple EC tablet event and TBMC device
This change decouples EC tablet event and TBMC device by guarding TBMC definition and notification using EC_ENABLE_TBMC_DEVICE. It allows mainboards to use tablet events without having to define a TBMC device. BUG=b:72554519 Change-Id: Ie38b6d68486e8e644dd0d6d406def3ae7fdb5152 Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://review.coreboot.org/23461 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/eve/ec.h2
-rw-r--r--src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h1
-rw-r--r--src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h2
3 files changed, 5 insertions, 0 deletions
diff --git a/src/mainboard/google/eve/ec.h b/src/mainboard/google/eve/ec.h
index 81d591cb40..1b55248081 100644
--- a/src/mainboard/google/eve/ec.h
+++ b/src/mainboard/google/eve/ec.h
@@ -79,6 +79,8 @@
/* Enable Tablet switch */
#define EC_ENABLE_TABLET_EVENT
+#define EC_ENABLE_TBMC_DEVICE
+
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
index ca9f865f19..70f12d5838 100644
--- a/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
+++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/ec.h
@@ -72,6 +72,7 @@
#define EC_ENABLE_LID_SWITCH
#define EC_ENABLE_WAKE_PIN GPE_EC_WAKE
#define EC_ENABLE_TABLET_EVENT
+#define EC_ENABLE_TBMC_DEVICE
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
index 1f91c1e6b9..ff32ff6b52 100644
--- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h
@@ -74,6 +74,8 @@
/* Enable Tablet switch */
#define EC_ENABLE_TABLET_EVENT
+#define EC_ENABLE_TBMC_DEVICE
+
#define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */