diff options
author | Stefan Reinauer <stepan@coresystems.de> | 2010-04-09 11:55:43 +0000 |
---|---|---|
committer | Stefan Reinauer <stepan@openbios.org> | 2010-04-09 11:55:43 +0000 |
commit | 0e34aeffd39bb672de520f403533efa2f77df1da (patch) | |
tree | 069b1a9adae957b01645f4b751b0f6d4688e31ca /src/mainboard | |
parent | c666a64395efd7472ff6f5de5589593c7d5f8e33 (diff) | |
download | coreboot-0e34aeffd39bb672de520f403533efa2f77df1da.tar.xz |
remove some amd mainboard warnings.
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5391 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard')
-rw-r--r-- | src/mainboard/amd/dbm690t/acpi_tables.c | 2 | ||||
-rw-r--r-- | src/mainboard/amd/dbm690t/mainboard.c | 13 | ||||
-rw-r--r-- | src/mainboard/amd/mahogany/get_bus_conf.c | 2 | ||||
-rw-r--r-- | src/mainboard/amd/pistachio/mainboard.c | 11 |
4 files changed, 11 insertions, 17 deletions
diff --git a/src/mainboard/amd/dbm690t/acpi_tables.c b/src/mainboard/amd/dbm690t/acpi_tables.c index 1014962584..041f880695 100644 --- a/src/mainboard/amd/dbm690t/acpi_tables.c +++ b/src/mainboard/amd/dbm690t/acpi_tables.c @@ -92,8 +92,6 @@ unsigned long acpi_fill_madt(unsigned long current) return current; } - - static void update_ssdtx(void *ssdtx, int i) { uint8_t *PCI; diff --git a/src/mainboard/amd/dbm690t/mainboard.c b/src/mainboard/amd/dbm690t/mainboard.c index c85c210a5b..dfee7c0479 100644 --- a/src/mainboard/amd/dbm690t/mainboard.c +++ b/src/mainboard/amd/dbm690t/mainboard.c @@ -22,6 +22,7 @@ #include <device/pci.h> #include <arch/io.h> #include <boot/coreboot_tables.h> +#include <arch/coreboot_tables.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> @@ -57,7 +58,7 @@ uint64_t uma_memory_base, uma_memory_size; * RRG4.2.3.1 GPM pins as Input * RRG4.2.3.2 GPM pins as Output ********************************************************/ -static void enable_onboard_nic() +static void enable_onboard_nic(void) { u8 byte; @@ -94,7 +95,7 @@ static void enable_onboard_nic() * IDE_DMA66 is routed to GPIO 9. So we read Gpio 9 to * get the cable type, 40 pin or 80 pin? ********************************************************/ -static void get_ide_dma66() +static void get_ide_dma66(void) { u8 byte; struct device *sm_dev; @@ -120,7 +121,7 @@ static void get_ide_dma66() /* * set thermal config */ -static void set_thermal_config() +static void set_thermal_config(void) { u8 byte; u16 word; @@ -185,11 +186,8 @@ static void set_thermal_config() * enable the dedicated function in dbm690t board. * This function called early than rs690_enable. *************************************************/ -void dbm690t_enable(device_t dev) +static void dbm690t_enable(device_t dev) { - struct mainboard_config *mainboard = - (struct mainboard_config *)dev->chip_info; - printk(BIOS_INFO, "Mainboard DBM690T Enable. dev=0x%p\n", dev); #if (CONFIG_GFXUMA == 1) @@ -249,6 +247,7 @@ int add_mainboard_resources(struct lb_memory *mem) lb_add_memory_range(mem, LB_MEM_RESERVED, uma_memory_base, uma_memory_size); #endif + return 0; } struct chip_operations mainboard_ops = { diff --git a/src/mainboard/amd/mahogany/get_bus_conf.c b/src/mainboard/amd/mahogany/get_bus_conf.c index e3c7acd226..43558ac984 100644 --- a/src/mainboard/amd/mahogany/get_bus_conf.c +++ b/src/mainboard/amd/mahogany/get_bus_conf.c @@ -63,8 +63,6 @@ u32 sbdn_sb700; static u32 get_bus_conf_done = 0; -void get_bus_conf(void); - void get_bus_conf(void) { u32 apicid_base; diff --git a/src/mainboard/amd/pistachio/mainboard.c b/src/mainboard/amd/pistachio/mainboard.c index 6688f06934..be36458204 100644 --- a/src/mainboard/amd/pistachio/mainboard.c +++ b/src/mainboard/amd/pistachio/mainboard.c @@ -22,6 +22,7 @@ #include <device/pci.h> #include <arch/io.h> #include <boot/coreboot_tables.h> +#include <arch/coreboot_tables.h> #include <cpu/x86/msr.h> #include <cpu/amd/mtrr.h> #include <device/pci_def.h> @@ -57,7 +58,7 @@ uint64_t uma_memory_base, uma_memory_size; * The R77 (on BRASS) / R81 (on Bronze) is not load! * So NIC can work whether this function runs. ********************************************************/ -static void enable_onboard_nic() +static void enable_onboard_nic(void) { u8 byte; @@ -77,7 +78,7 @@ static void enable_onboard_nic() /* * set thermal config */ -static void set_thermal_config() +static void set_thermal_config(void) { u8 byte, byte2; u16 word; @@ -256,11 +257,8 @@ static void set_thermal_config() * enable the dedicated function in pistachio board. * This function called early than rs690_enable. *************************************************/ -void pistachio_enable(device_t dev) +static void pistachio_enable(device_t dev) { - struct mainboard_config *mainboard = - (struct mainboard_config *)dev->chip_info; - printk(BIOS_INFO, "Mainboard Pistachio Enable. dev=0x%p\n", dev); #if (CONFIG_GFXUMA == 1) @@ -320,6 +318,7 @@ int add_mainboard_resources(struct lb_memory *mem) lb_add_memory_range(mem, LB_MEM_RESERVED, uma_memory_base, uma_memory_size); #endif + return 0; } struct chip_operations mainboard_ops = { |