summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorJacob Garber <jgarber1@ualberta.ca>2020-08-24 18:33:40 -0600
committerPatrick Georgi <pgeorgi@google.com>2020-08-26 07:35:41 +0000
commit3c16fe4fade9f1c695a52e756fa638cb8cd0e9f6 (patch)
tree88c055f3f6aefbf44420267ce9c9fb1533183521 /src/mainboard
parentb126380b0018f2777e0bcd75460161e30e9b005a (diff)
downloadcoreboot-3c16fe4fade9f1c695a52e756fa638cb8cd0e9f6.tar.xz
mb/google/deltaur: Make return values non-const
Returning a const uint32_t doesn't do anything, and it conflicts with the declaration of sku_id() in include/boardid.h. Change-Id: I2719e5782c9977f8ca4ce8f1dd781f092aa73d64 Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Found-by: Coverity CID 1428708 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44746 Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/deltaur/variants/baseboard/sku.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/google/deltaur/variants/baseboard/sku.c b/src/mainboard/google/deltaur/variants/baseboard/sku.c
index fb19e3c67f..3cd279ec10 100644
--- a/src/mainboard/google/deltaur/variants/baseboard/sku.c
+++ b/src/mainboard/google/deltaur/variants/baseboard/sku.c
@@ -6,12 +6,12 @@
#include <smbios.h>
#include <variant/variant.h>
-static const uint32_t get_sku_index(void)
+static uint32_t get_sku_index(void)
{
return ((!has_360_sensor_board()) | (wilco_ec_signed_fw() << 1));
}
-const uint32_t sku_id(void)
+uint32_t sku_id(void)
{
return skus[get_sku_index()].id;
}