diff options
| author | Julius Werner <jwerner@chromium.org> | 2013-08-29 14:17:36 -0700 |
|---|---|---|
| committer | Isaac Christensen <isaac.christensen@se-eng.com> | 2014-08-14 01:43:11 +0200 |
| commit | fa938c7508627c0dfcf03960957ef8631fc53f02 (patch) | |
| tree | 369a6f41d6a4a152ec933b08e869d6bb527adac4 /src/mainboard | |
| parent | 755615a12310469b34fc4804bcf2622eb587949c (diff) | |
| download | coreboot-fa938c7508627c0dfcf03960957ef8631fc53f02.tar.xz | |
exynos5: Refactor crazy old U-Boot base address macros away
All this samsung_get_base_address_of_device_with_a_really_long_name()
boilerplate makes my eyes bleed... I think there are so much cleaner
ways to do this. Unfortunately changing this ends up touching nearly
every Exynos5 file, but I hope you agree that it's worth it (and the
sooner we get it over with, the better... I can't bring myself to make
another device fit into that ugly scheme).
This also removes the redundant EXYNOS5 base address definitions from
the 5420 directory when there are EXYNOS5420 ones, to avoid complete
confusion. The new scheme tries to use EXYNOS5 for base addresses and
exynos5 for types that are common between the two processors, and
EXYNOS5420/exynos5420 for things that have changes (although I probably
didn't catch all differences).
Change-Id: I87e58434490ed55a9bbe743af1f9bf2520dec13f
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/167579
Reviewed-by: Stefan Reinauer <reinauer@google.com>
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: ron minnich <rminnich@chromium.org>
(cherry picked from commit 66c87693352c248eec029c1ce83fb295059e6b5b)
Signed-off-by: Isaac Christensen <isaac.christensen@se-eng.com>
Reviewed-on: http://review.coreboot.org/6632
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/google/pit/mainboard.c | 1 | ||||
| -rw-r--r-- | src/mainboard/google/snow/mainboard.c | 5 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/mainboard/google/pit/mainboard.c b/src/mainboard/google/pit/mainboard.c index 467b9d04e9..bdf2d571b2 100644 --- a/src/mainboard/google/pit/mainboard.c +++ b/src/mainboard/google/pit/mainboard.c @@ -331,7 +331,6 @@ static struct edp_video_info dp_video_info = { }; /* FIXME: move some place more appropriate */ -#define EXYNOS5420_DP1_BASE 0x145b0000 #define MAX_DP_TRIES 5 static void setup_storage(void) diff --git a/src/mainboard/google/snow/mainboard.c b/src/mainboard/google/snow/mainboard.c index dfaf81d537..756dc15325 100644 --- a/src/mainboard/google/snow/mainboard.c +++ b/src/mainboard/google/snow/mainboard.c @@ -30,11 +30,11 @@ #include <arch/exception.h> #include <cpu/samsung/exynos5250/tmu.h> #include <cpu/samsung/exynos5250/clk.h> -#include <cpu/samsung/exynos5250/cpu.h> #include <cpu/samsung/exynos5250/gpio.h> #include <cpu/samsung/exynos5250/power.h> #include <cpu/samsung/exynos5250/i2c.h> #include <cpu/samsung/exynos5250/dp-core.h> +#include <cpu/samsung/exynos5250/dp.h> #include <cpu/samsung/exynos5250/usb.h> #include "exynos5250.h" @@ -193,7 +193,6 @@ static struct video_info dp_video_info = { }; /* FIXME: move some place more appropriate */ -#define EXYNOS5250_DP1_BASE 0x145b0000 #define MAX_DP_TRIES 5 /* @@ -256,7 +255,7 @@ static void mainboard_init(device_t dev) { int dp_tries; struct s5p_dp_device dp_device = { - .base = (struct exynos5_dp *)EXYNOS5250_DP1_BASE, + .base = exynos_dp1, .video_info = &dp_video_info, }; void *fb_addr = (void *)(get_fb_base_kb() * KiB); |