summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2020-08-26 20:07:31 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-09-11 22:32:52 +0000
commit92c4bc19e93e2036f826c03a0cd32855601d0381 (patch)
tree0a3fb539332a7a0cd0dede06d280c636c8a20bb7 /src/mainboard
parentc06c0ce55943cc0f1ec8424aba519bb666f1c973 (diff)
downloadcoreboot-92c4bc19e93e2036f826c03a0cd32855601d0381.tar.xz
mb/kontron/ktqm77: Use 'PNP_IDX_*' instead of magic numbers
Change-Id: Ic4f51a59524bacb374d90c5620f810e96d7b8eb2 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/44839 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/kontron/ktqm77/early_init.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mainboard/kontron/ktqm77/early_init.c b/src/mainboard/kontron/ktqm77/early_init.c
index c326795e28..8df1a5e84e 100644
--- a/src/mainboard/kontron/ktqm77/early_init.c
+++ b/src/mainboard/kontron/ktqm77/early_init.c
@@ -2,6 +2,7 @@
#include <bootblock_common.h>
#include <stdint.h>
+#include <device/pnp_def.h>
#include <device/pnp_ops.h>
#include <device/pci_ops.h>
#include <device/pci_def.h>
@@ -35,7 +36,7 @@ void bootblock_mainboard_early_init(void)
const pnp_devfn_t dev = PNP_DEV(0x2e, 0x9);
pnp_enter_conf_state(dev);
pnp_write_config(dev, 0x29, 0x02); /* Pins 119, 120 are GPIO21, 20 */
- pnp_write_config(dev, 0x30, 0x03); /* Enable GPIO2+3 */
+ pnp_write_config(dev, PNP_IDX_EN, 0x03); /* Enable GPIO2+3 */
pnp_write_config(dev, 0x2a, 0x01); /* Pins 62, 63, 65, 66 are
GPIO27, 26, 25, 24 */
pnp_write_config(dev, 0x2c, 0xc3); /* Pin 90 is GPIO32,
@@ -46,7 +47,8 @@ void bootblock_mainboard_early_init(void)
/* Values can only be changed, when devices are enabled. */
pnp_write_config(dev, 0xe3, 0xdd); /* GPIO2 bits 1, 5 are output */
pnp_write_config(dev, 0xe4, (dis_bl_inv << 5) | (lvds_3v << 1)); /* GPIO2 bits 1, 5 */
- pnp_write_config(dev, 0xf3, 0x40); /* Disable suspend LED during normal operation */
+ /* Disable suspend LED during normal operation */
+ pnp_write_config(dev, PNP_IDX_MSC3, 0x40);
pnp_exit_conf_state(dev);
}