summaryrefslogtreecommitdiff
path: root/src/mainboard
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2020-08-07 18:31:20 +0000
committerAaron Durbin <adurbin@chromium.org>2020-08-07 22:28:46 +0000
commit81066b7ce7192432389578fc0f15b3a46da84bad (patch)
tree7da1915d45c86bec1717ccdd17a1b3b0c07ce1af /src/mainboard
parent9c1c00968c943659bab2a817892e5a9be9dfb7c0 (diff)
downloadcoreboot-81066b7ce7192432389578fc0f15b3a46da84bad.tar.xz
mb/google/zork: Revert Don't expose reset GPIO for touchscreen to OS
This reverts the code from commit 728c0787f2 that removes the reset GPIO from the touchscreen ACPI interface. That patch exposes a bug which leads to an invalid opcode trap in the touchscreen code. Reverting this gets the system working again, but is not a long-term solution. BUG=b:162596241 TEST=System boots to login screen. Change-Id: I57a070d94f961cec43834c8bedd5dafc8a54171a Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/43078 Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/mainboard')
-rw-r--r--src/mainboard/google/zork/variants/berknip/overridetree.cb1
-rw-r--r--src/mainboard/google/zork/variants/dalboz/overridetree.cb1
-rw-r--r--src/mainboard/google/zork/variants/ezkinil/overridetree.cb1
-rw-r--r--src/mainboard/google/zork/variants/trembyle/overridetree.cb1
4 files changed, 0 insertions, 4 deletions
diff --git a/src/mainboard/google/zork/variants/berknip/overridetree.cb b/src/mainboard/google/zork/variants/berknip/overridetree.cb
index 58f5844ef3..a469fb9340 100644
--- a/src/mainboard/google/zork/variants/berknip/overridetree.cb
+++ b/src/mainboard/google/zork/variants/berknip/overridetree.cb
@@ -78,7 +78,6 @@ chip soc/amd/picasso
# 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1"
- register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
chip drivers/i2c/generic
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb
index 8735a06921..9148936037 100644
--- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb
+++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb
@@ -53,7 +53,6 @@ chip soc/amd/picasso
# 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1"
- register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
chip drivers/i2c/generic
diff --git a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb
index 6a88b78201..6b4331fe69 100644
--- a/src/mainboard/google/zork/variants/ezkinil/overridetree.cb
+++ b/src/mainboard/google/zork/variants/ezkinil/overridetree.cb
@@ -80,7 +80,6 @@ chip soc/amd/picasso
# 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1"
- register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
chip drivers/i2c/hid
diff --git a/src/mainboard/google/zork/variants/trembyle/overridetree.cb b/src/mainboard/google/zork/variants/trembyle/overridetree.cb
index 9e7660b234..fb922b9de3 100644
--- a/src/mainboard/google/zork/variants/trembyle/overridetree.cb
+++ b/src/mainboard/google/zork/variants/trembyle/overridetree.cb
@@ -76,7 +76,6 @@ chip soc/amd/picasso
# 20ms: Firmware ready time
register "reset_delay_ms" = "32 + 20"
register "has_power_resource" = "1"
- register "disable_gpio_export_in_crs" = "1"
device i2c 39 on end
end
chip drivers/i2c/generic