diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-09-25 14:23:31 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-09-25 14:23:31 +0000 |
| commit | 370d979a93b1a63d1f8afc1ec2eb7cf54947ce35 (patch) | |
| tree | 938036d81b7d1a128d6d90c8d2d6a5bc4aa6287c /src/mainboard | |
| parent | bcabf2fa749f0690da982aaba52d9045f231c119 (diff) | |
| download | coreboot-370d979a93b1a63d1f8afc1ec2eb7cf54947ce35.tar.xz | |
Various USB Debug Port fixes (trivial).
- Drop unused DBGP_DEFAULT #defines on boards with chipsets where no
USB Debug Port support is implemented anyway (at the moment, at least):
- hp/dl145_g3
- hp/dl165_g6_fam10
- ICH7: Move unrelated code out of set_debug_port(). All ICH southbridges
with Debug Port hardcode the physical USB port used as Debug Port to 1.
In other words, this port is not user-configurable (as seems to be
the case on NVIDIA MCP55). For now we keep the 'port' parameter in order
to not change the API, this might be fixed differently later.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5842 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/mainboard')
| -rw-r--r-- | src/mainboard/getac/p470/romstage.c | 3 | ||||
| -rw-r--r-- | src/mainboard/hp/dl145_g3/romstage.c | 2 | ||||
| -rw-r--r-- | src/mainboard/hp/dl165_g6_fam10/romstage.c | 2 | ||||
| -rw-r--r-- | src/mainboard/ibase/mb899/romstage.c | 3 | ||||
| -rw-r--r-- | src/mainboard/intel/d945gclf/romstage.c | 3 | ||||
| -rw-r--r-- | src/mainboard/kontron/986lcd-m/romstage.c | 4 | ||||
| -rw-r--r-- | src/mainboard/roda/rk886ex/romstage.c | 3 |
7 files changed, 5 insertions, 15 deletions
diff --git a/src/mainboard/getac/p470/romstage.c b/src/mainboard/getac/p470/romstage.c index 9f7c14af52..7c55d0c591 100644 --- a/src/mainboard/getac/p470/romstage.c +++ b/src/mainboard/getac/p470/romstage.c @@ -37,7 +37,6 @@ #include <cpu/x86/bist.h> #if CONFIG_USBDEBUG -#define DBGP_DEFAULT 0 #include "southbridge/intel/i82801gx/i82801gx_usb_debug.c" #include "pc80/usbdebug_serial.c" #endif @@ -319,7 +318,7 @@ void main(unsigned long bist) uart_init(); #if CONFIG_USBDEBUG - i82801gx_enable_usbdebug(DBGP_DEFAULT); + i82801gx_enable_usbdebug(1); early_usbdebug_init(); #endif console_init(); diff --git a/src/mainboard/hp/dl145_g3/romstage.c b/src/mainboard/hp/dl145_g3/romstage.c index fb0d5eb5d5..8f3e21ddbe 100644 --- a/src/mainboard/hp/dl145_g3/romstage.c +++ b/src/mainboard/hp/dl145_g3/romstage.c @@ -44,8 +44,6 @@ #define K8_REV_F_SUPPORT_F0_F1_WORKAROUND 0 #endif -#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> diff --git a/src/mainboard/hp/dl165_g6_fam10/romstage.c b/src/mainboard/hp/dl165_g6_fam10/romstage.c index 0e0347d8c8..74ded075e9 100644 --- a/src/mainboard/hp/dl165_g6_fam10/romstage.c +++ b/src/mainboard/hp/dl165_g6_fam10/romstage.c @@ -39,8 +39,6 @@ #define SET_FIDVID 1 #define SET_FIDVID_CORE_RANGE 0 -#define DBGP_DEFAULT 7 - #include <stdint.h> #include <string.h> #include <device/pci_def.h> diff --git a/src/mainboard/ibase/mb899/romstage.c b/src/mainboard/ibase/mb899/romstage.c index 8d4ca81254..4c953d7ab1 100644 --- a/src/mainboard/ibase/mb899/romstage.c +++ b/src/mainboard/ibase/mb899/romstage.c @@ -40,7 +40,6 @@ #include <cpu/x86/bist.h> #if CONFIG_USBDEBUG -#define DBGP_DEFAULT 1 #include "southbridge/intel/i82801gx/i82801gx_usb_debug.c" #include "pc80/usbdebug_serial.c" #endif @@ -275,7 +274,7 @@ void main(unsigned long bist) uart_init(); #if CONFIG_USBDEBUG - i82801gx_enable_usbdebug(DBGP_DEFAULT); + i82801gx_enable_usbdebug(1); early_usbdebug_init(); #endif diff --git a/src/mainboard/intel/d945gclf/romstage.c b/src/mainboard/intel/d945gclf/romstage.c index 43681a2d14..0b5c9c9cdb 100644 --- a/src/mainboard/intel/d945gclf/romstage.c +++ b/src/mainboard/intel/d945gclf/romstage.c @@ -39,7 +39,6 @@ #include <cpu/x86/bist.h> #if CONFIG_USBDEBUG -#define DBGP_DEFAULT 1 #include "southbridge/intel/i82801gx/i82801gx_usb_debug.c" #include "pc80/usbdebug_serial.c" #endif @@ -236,7 +235,7 @@ void main(unsigned long bist) uart_init(); #if CONFIG_USBDEBUG - i82801gx_enable_usbdebug(DBGP_DEFAULT); + i82801gx_enable_usbdebug(1); early_usbdebug_init(); #endif diff --git a/src/mainboard/kontron/986lcd-m/romstage.c b/src/mainboard/kontron/986lcd-m/romstage.c index b3acece1f5..e400feea47 100644 --- a/src/mainboard/kontron/986lcd-m/romstage.c +++ b/src/mainboard/kontron/986lcd-m/romstage.c @@ -49,8 +49,6 @@ #include <cpu/x86/bist.h> #if CONFIG_USBDEBUG -#define DBGP_DEFAULT 1 -#include <usbdebug.h> #include "southbridge/intel/i82801gx/i82801gx_usb_debug.c" #include "pc80/usbdebug_serial.c" #endif @@ -379,7 +377,7 @@ void main(unsigned long bist) uart_init(); #if CONFIG_USBDEBUG - i82801gx_enable_usbdebug(DBGP_DEFAULT); + i82801gx_enable_usbdebug(1); early_usbdebug_init(); #endif diff --git a/src/mainboard/roda/rk886ex/romstage.c b/src/mainboard/roda/rk886ex/romstage.c index 00c4c9f446..a3e96651aa 100644 --- a/src/mainboard/roda/rk886ex/romstage.c +++ b/src/mainboard/roda/rk886ex/romstage.c @@ -41,7 +41,6 @@ #include <cpu/x86/bist.h> #if CONFIG_USBDEBUG -#define DBGP_DEFAULT 1 #include "southbridge/intel/i82801gx/i82801gx_usb_debug.c" #include "pc80/usbdebug_serial.c" #endif @@ -291,7 +290,7 @@ void main(unsigned long bist) uart_init(); #if CONFIG_USBDEBUG - i82801gx_enable_usbdebug(DBGP_DEFAULT); + i82801gx_enable_usbdebug(1); early_usbdebug_init(); #endif |