diff options
| author | Stefan Reinauer <reinauer@chromium.org> | 2015-01-05 12:59:54 -0800 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2015-01-06 20:15:02 +0100 |
| commit | 65b72ab55d7dff1f13cdf495d345e04e634b97ac (patch) | |
| tree | 11771914bc4459d7cf9e020ff4489e9bb6a81e75 /src/northbridge/amd/amdk8/debug.c | |
| parent | d42c9dae8528594b2ab8534d061c118c15e92d3d (diff) | |
| download | coreboot-65b72ab55d7dff1f13cdf495d345e04e634b97ac.tar.xz | |
northbridge: Drop print_ implementation from non-romcc boards
Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*. Back in the day, like more than
half a decade ago, we migrated a lot of boards to printk, but we never
cleaned up the existing code to be consistent. instead, we worked around
the problem with a very messy console.h (nowadays the mess is hidden in
romstage_console.c and early_print.h)
This patch cleans up the northbridge code to use printk() on all non-ROMCC
boards.
Change-Id: I4a36cd965c58aae65d74ce1e697dc0d0f58f47a1
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/7856
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/northbridge/amd/amdk8/debug.c')
| -rw-r--r-- | src/northbridge/amd/amdk8/debug.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/src/northbridge/amd/amdk8/debug.c b/src/northbridge/amd/amdk8/debug.c index 4f9d8cafa9..c1021e5736 100644 --- a/src/northbridge/amd/amdk8/debug.c +++ b/src/northbridge/amd/amdk8/debug.c @@ -54,7 +54,7 @@ static void dump_pci_device(unsigned dev) val = pci_read_config8(dev, i); printk(BIOS_DEBUG, " %02x", val); } - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); } #if CONFIG_K8_REV_F_SUPPORT @@ -63,7 +63,7 @@ static inline void dump_pci_device_index_wait(unsigned dev, uint32_t index_reg) { int i; print_debug_pci_dev(dev); - print_debug(" -- index_reg="); print_debug_hex32(index_reg); + printk(BIOS_DEBUG, " -- index_reg=%08x", index_reg); for(i = 0; i < 0x40; i++) { uint32_t val; @@ -76,7 +76,7 @@ static inline void dump_pci_device_index_wait(unsigned dev, uint32_t index_reg) } } - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); } #endif @@ -135,7 +135,7 @@ static inline void dump_pci_devices_on_bus(unsigned busn) static void dump_spd_registers(const struct mem_controller *ctrl) { int i; - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); for(i = 0; i < 4; i++) { unsigned device; device = ctrl->channel0[i]; @@ -155,7 +155,7 @@ static void dump_spd_registers(const struct mem_controller *ctrl) byte = status & 0xff; printk(BIOS_DEBUG, "%02x ", byte); } - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); } device = ctrl->channel1[i]; if (device) { @@ -174,14 +174,14 @@ static void dump_spd_registers(const struct mem_controller *ctrl) byte = status & 0xff; printk(BIOS_DEBUG, "%02x ", byte); } - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); } } } static void dump_smbus_registers(void) { unsigned device; - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); for(device = 1; device < 0x80; device++) { int j; if( smbus_read_byte(device, 0) < 0 ) continue; @@ -199,7 +199,7 @@ static void dump_smbus_registers(void) byte = status & 0xff; printk(BIOS_DEBUG, "%02x ", byte); } - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); } } #endif @@ -218,7 +218,7 @@ static inline void dump_io_resources(unsigned port) val = inb(port); printk(BIOS_DEBUG, " %02x",val); if ((i & 0x0f) == 0x0f) { - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); } port++; } @@ -227,13 +227,13 @@ static inline void dump_io_resources(unsigned port) static inline void dump_mem(unsigned start, unsigned end) { unsigned i; - print_debug("dump_mem:"); + printk(BIOS_DEBUG, "dump_mem:"); for(i=start;i<end;i++) { if((i & 0xf)==0) { printk(BIOS_DEBUG, "\n%08x:", i); } printk(BIOS_DEBUG, " %02x", (unsigned char)*((unsigned char *)i)); } - print_debug("\n"); + printk(BIOS_DEBUG, "\n"); } #endif |