diff options
author | Angel Pons <th3fanbus@gmail.com> | 2020-07-03 14:14:30 +0200 |
---|---|---|
committer | Angel Pons <th3fanbus@gmail.com> | 2020-07-12 09:54:50 +0000 |
commit | 6eea191511ad63017eafa22d5363a39ac99ab1db (patch) | |
tree | eadc730127331a8bf9454696146d18f7dc042d61 /src/northbridge/intel/haswell/romstage.c | |
parent | 517bc99db1ece3f3904534e9f0d5d3b28eb4815b (diff) | |
download | coreboot-6eea191511ad63017eafa22d5363a39ac99ab1db.tar.xz |
haswell: Make `copy_spd` a weak function
Instead of using function pointers, we can use weak functions. So, drop
the pointer from `romstage_params`, leaving `pei_data` as the only
remaining member. This will be cleaned up in a follow-up commit.
Change-Id: I3b17d21ea7a650734119a5cab4892fcb158b589d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43105
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/northbridge/intel/haswell/romstage.c')
-rw-r--r-- | src/northbridge/intel/haswell/romstage.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/northbridge/intel/haswell/romstage.c b/src/northbridge/intel/haswell/romstage.c index ae9d707d90..00f5f47938 100644 --- a/src/northbridge/intel/haswell/romstage.c +++ b/src/northbridge/intel/haswell/romstage.c @@ -13,6 +13,11 @@ #include <southbridge/intel/lynxpoint/pch.h> #include <southbridge/intel/lynxpoint/me.h> +/* Copy SPD data for on-board memory */ +void __weak copy_spd(struct pei_data *peid) +{ +} + void __weak mb_late_romstage_setup(void) { } @@ -53,8 +58,7 @@ void romstage_common(const struct romstage_params *params) report_platform_info(); - if (params->copy_spd != NULL) - params->copy_spd(params->pei_data); + copy_spd(params->pei_data); sdram_initialize(params->pei_data); |