diff options
| author | Elyes HAOUAS <ehaouas@noos.fr> | 2020-04-04 12:26:35 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-04-05 13:31:28 +0000 |
| commit | deeccbf4e96de1cd4ed136f865b96a90db374886 (patch) | |
| tree | b81adfab9c6375bf75196226995aa78e2da247ec /src/northbridge/intel/haswell | |
| parent | 7c45c8363d86280d70cb671ea713a06fd462a6e7 (diff) | |
| download | coreboot-deeccbf4e96de1cd4ed136f865b96a90db374886.tar.xz | |
Drop explicit NULL initializations from `device_operations`
Unmentioned fields are initialized with 0 (or NULL) implicitly. Beside
that, the struct has grown over the years. There are too many optional
fields to list them all.
Change-Id: Icb9e14c58153d7c14817bcde148e86e977666e4b
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40126
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/northbridge/intel/haswell')
| -rw-r--r-- | src/northbridge/intel/haswell/gma.c | 2 | ||||
| -rw-r--r-- | src/northbridge/intel/haswell/minihd.c | 1 | ||||
| -rw-r--r-- | src/northbridge/intel/haswell/northbridge.c | 4 |
3 files changed, 0 insertions, 7 deletions
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 4c11bd1c64..8c28c53a3f 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -565,8 +565,6 @@ static struct device_operations gma_func0_ops = { .enable_resources = pci_dev_enable_resources, .init = gma_func0_init, .acpi_fill_ssdt = gma_generate_ssdt, - .scan_bus = NULL, - .enable = NULL, .ops_pci = &gma_pci_ops, .write_acpi_tables = gma_write_acpi_tables, }; diff --git a/src/northbridge/intel/haswell/minihd.c b/src/northbridge/intel/haswell/minihd.c index 5a1e7a8ef9..9cd7ad4889 100644 --- a/src/northbridge/intel/haswell/minihd.c +++ b/src/northbridge/intel/haswell/minihd.c @@ -106,7 +106,6 @@ static struct device_operations minihd_ops = { .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = minihd_init, - .scan_bus = NULL, .ops_pci = &minihd_pci_ops, }; diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c index 4e16ca06e3..b764aadb30 100644 --- a/src/northbridge/intel/haswell/northbridge.c +++ b/src/northbridge/intel/haswell/northbridge.c @@ -92,8 +92,6 @@ static const char *northbridge_acpi_name(const struct device *dev) static struct device_operations pci_domain_ops = { .read_resources = pci_domain_read_resources, .set_resources = pci_domain_set_resources, - .enable_resources = NULL, - .init = NULL, .scan_bus = pci_domain_scan_bus, .acpi_name = northbridge_acpi_name, .write_acpi_tables = northbridge_write_acpi_tables, @@ -477,7 +475,6 @@ static struct device_operations mc_ops = { .enable_resources = pci_dev_enable_resources, .init = northbridge_init, .acpi_fill_ssdt = generate_cpu_entries, - .scan_bus = NULL, .ops_pci = &intel_pci_ops, }; @@ -500,7 +497,6 @@ static struct device_operations cpu_bus_ops = { .set_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP, .init = mp_cpu_bus_init, - .scan_bus = NULL, }; static void enable_dev(struct device *dev) |