diff options
| author | Stefan Reinauer <stepan@coresystems.de> | 2010-03-30 22:12:59 +0000 |
|---|---|---|
| committer | Stefan Reinauer <stepan@openbios.org> | 2010-03-30 22:12:59 +0000 |
| commit | 3ac400e6e57f2efc8db06b9b3206b253d142c741 (patch) | |
| tree | db35cd370855cf37995bebc953ba6781d62b222d /src/northbridge/intel/i82810 | |
| parent | b01fe696d495cfd15f861d270c88547aabf1f6c4 (diff) | |
| download | coreboot-3ac400e6e57f2efc8db06b9b3206b253d142c741.tar.xz | |
drop USE_INIT should be USE_PRINTK_IN_CAR here.
uint32_t should be u32
DEBUG_RAM_SETUP was failing on some northbridges
Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5338 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/northbridge/intel/i82810')
| -rw-r--r-- | src/northbridge/intel/i82810/northbridge.c | 2 | ||||
| -rw-r--r-- | src/northbridge/intel/i82810/raminit.c | 16 |
2 files changed, 12 insertions, 6 deletions
diff --git a/src/northbridge/intel/i82810/northbridge.c b/src/northbridge/intel/i82810/northbridge.c index 952455a672..5b68046e7e 100644 --- a/src/northbridge/intel/i82810/northbridge.c +++ b/src/northbridge/intel/i82810/northbridge.c @@ -208,8 +208,6 @@ static struct device_operations cpu_bus_ops = { static void enable_dev(struct device *dev) { - struct device_path path; - /* Set the operations if it is a special bus type */ if (dev->path.type == DEVICE_PATH_PCI_DOMAIN) { dev->ops = &pci_domain_ops; diff --git a/src/northbridge/intel/i82810/raminit.c b/src/northbridge/intel/i82810/raminit.c index 5ad4e4be73..e88580c5e8 100644 --- a/src/northbridge/intel/i82810/raminit.c +++ b/src/northbridge/intel/i82810/raminit.c @@ -30,12 +30,17 @@ Macros and definitions. -----------------------------------------------------------------------------*/ /* Debugging macros. */ +#define HAVE_ENOUGH_REGISTERS 0 /* Don't have enough registers to compile all + * debugging code with ROMCC + */ #if CONFIG_DEBUG_RAM_SETUP #define PRINT_DEBUG(x) print_debug(x) #define PRINT_DEBUG_HEX8(x) print_debug_hex8(x) #define PRINT_DEBUG_HEX16(x) print_debug_hex16(x) #define PRINT_DEBUG_HEX32(x) print_debug_hex32(x) -#define DUMPNORTH() dump_pci_device(PCI_DEV(0, 0, 0)) +// no dump_pci_device in src/northbridge/intel/i82810/ +// #define DUMPNORTH() dump_pci_device(PCI_DEV(0, 0, 0)) +#define DUMPNORTH() #else #define PRINT_DEBUG(x) #define PRINT_DEBUG_HEX8(x) @@ -138,26 +143,29 @@ static void do_ram_command(u8 command) drp = (drp >> (i * 4)) & 0x0f; dimm_size = translate_i82810_to_mb[drp]; - addr = (dimm_start * 1024 * 1024) + addr_offset; if (dimm_size) { + addr = (dimm_start * 1024 * 1024) + addr_offset; +#if HAVE_ENOUGH_REGISTERS PRINT_DEBUG(" Sending RAM command 0x"); PRINT_DEBUG_HEX8(reg8); PRINT_DEBUG(" to 0x"); PRINT_DEBUG_HEX32(addr); PRINT_DEBUG("\r\n"); +#endif read32(addr); } dimm_bank = translate_i82810_to_bank[drp]; - addr = ((dimm_start + dimm_bank) * 1024 * 1024) + addr_offset; if (dimm_bank) { + addr = ((dimm_start + dimm_bank) * 1024 * 1024) + addr_offset; +#if HAVE_ENOUGH_REGISTERS PRINT_DEBUG(" Sending RAM command 0x"); PRINT_DEBUG_HEX8(reg8); PRINT_DEBUG(" to 0x"); PRINT_DEBUG_HEX32(addr); PRINT_DEBUG("\r\n"); - +#endif read32(addr); } |