summaryrefslogtreecommitdiff
path: root/src/northbridge/intel/i945
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2014-05-31 11:32:54 +0300
committerKyösti Mälkki <kyosti.malkki@gmail.com>2014-05-31 14:33:43 +0200
commit3c3e34d69fe4b185d4c0b698dfc6fcbf11b50dbb (patch)
tree9bd8c7ba4ca3a232deaeab0247b1b0a521cccfaa /src/northbridge/intel/i945
parent66f10b1a193b0c8cedbd32c2a83fc9e3b129648c (diff)
downloadcoreboot-3c3e34d69fe4b185d4c0b698dfc6fcbf11b50dbb.tar.xz
i945: Use defines for DEVEN
Change-Id: I32461449354155510c0e14e9d0ce396068ea50d4 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/5890 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Idwer Vollering <vidwer@gmail.com>
Diffstat (limited to 'src/northbridge/intel/i945')
-rw-r--r--src/northbridge/intel/i945/early_init.c11
-rw-r--r--src/northbridge/intel/i945/ram_calc.c2
2 files changed, 6 insertions, 7 deletions
diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c
index 57232af140..a55ea05939 100644
--- a/src/northbridge/intel/i945/early_init.c
+++ b/src/northbridge/intel/i945/early_init.c
@@ -248,7 +248,7 @@ static void i945_setup_egress_port(void)
}
/* Is internal graphics enabled? */
- if (pci_read_config8(PCI_DEV(0, 0x0, 0), 0x54) & ((1 << 4) | (1 << 3))) { /* DEVEN */
+ if (pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & (DEVEN_D2F0 | DEVEN_D2F1)) {
MCHBAR32(MMARB1) |= (1 << 17);
}
@@ -431,7 +431,7 @@ static void i945_setup_dmi_rcrb(void)
#endif
DMIBAR32(0x204) = reg32;
- if (pci_read_config8(PCI_DEV(0, 0x0, 0), 0x54) & ((1 << 4) | (1 << 3))) { /* DEVEN */
+ if (pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & (DEVEN_D2F0 | DEVEN_D2F1)) {
printk(BIOS_DEBUG, "Internal graphics: enabled\n");
DMIBAR32(0x200) |= (1 << 21);
} else {
@@ -649,10 +649,9 @@ static void i945_setup_pci_express_x16(void)
reg16 = (1 << 1);
pci_write_config16(PCI_DEV(0, 0x0, 0), 0x52, reg16);
- /* DEVEN */
- reg32 = pci_read_config32(PCI_DEV(0, 0x0, 0), 0x54);
- reg32 &= ~((1 << 3) | (1 << 4));
- pci_write_config32(PCI_DEV(0, 0x0, 0), 0x54, reg32);
+ reg32 = pci_read_config32(PCI_DEV(0, 0x0, 0), DEVEN);
+ reg32 &= ~(DEVEN_D2F0 | DEVEN_D2F1);
+ pci_write_config32(PCI_DEV(0, 0x0, 0), DEVEN, reg32);
/* Set VGA enable bit in PCIe bridge */
reg16 = pci_read_config16(PCI_DEV(0, 0x1, 0), 0x3e);
diff --git a/src/northbridge/intel/i945/ram_calc.c b/src/northbridge/intel/i945/ram_calc.c
index 51eb0ff463..23e3f41fa4 100644
--- a/src/northbridge/intel/i945/ram_calc.c
+++ b/src/northbridge/intel/i945/ram_calc.c
@@ -28,7 +28,7 @@ unsigned long get_top_of_ram(void)
{
u32 tom;
- if (pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & ((1 << 4) | (1 << 3))) {
+ if (pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & (DEVEN_D2F0 | DEVEN_D2F1)) {
/* IGD enabled, get top of Memory from BSM register */
tom = pci_read_config32(PCI_DEV(0,2,0), BSM);
} else {