summaryrefslogtreecommitdiff
path: root/src/northbridge/intel/i945
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2017-02-16 18:59:13 +0100
committerMartin Roth <martinroth@google.com>2017-02-20 04:42:47 +0100
commit75da1fb2baca8ce5c54d4a1ad4eb9f411844cbaa (patch)
treebed454b911e919660ae274d083be39f2d31f8f31 /src/northbridge/intel/i945
parentf797a1ac6a72a571ba76bff8b7c451cc090778a9 (diff)
downloadcoreboot-75da1fb2baca8ce5c54d4a1ad4eb9f411844cbaa.tar.xz
nb/i945/raminit: sdram_set_channel_mode Test if DIMM slot 3 is populated
Add a test in case we have a DIMM2 not populated but DIMM3 is. Change-Id: I14f82afe03884740570838e7b2771233356c518d Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/18386 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/northbridge/intel/i945')
-rw-r--r--src/northbridge/intel/i945/raminit.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index cc227cc50e..db49d0a42c 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -1943,8 +1943,9 @@ static void sdram_set_channel_mode(struct sys_info *sysinfo)
/* Channel 1 only */
printk(BIOS_DEBUG, "Single Channel 1 only.\n");
reg32 |= (1 << 2);
- } else if (sdram_capabilities_dual_channel() && sysinfo->dimm[2] !=
- SYSINFO_DIMM_NOT_POPULATED) {
+ } else if (sdram_capabilities_dual_channel() &&
+ (sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED ||
+ sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) {
/* Dual Channel Asymmetric */
printk(BIOS_DEBUG, "Dual Channel Asymmetric.\n");
reg32 |= (1 << 0);