diff options
| author | Elyes HAOUAS <ehaouas@noos.fr> | 2020-04-04 12:26:35 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-04-05 13:31:28 +0000 |
| commit | deeccbf4e96de1cd4ed136f865b96a90db374886 (patch) | |
| tree | b81adfab9c6375bf75196226995aa78e2da247ec /src/northbridge/intel/i945 | |
| parent | 7c45c8363d86280d70cb671ea713a06fd462a6e7 (diff) | |
| download | coreboot-deeccbf4e96de1cd4ed136f865b96a90db374886.tar.xz | |
Drop explicit NULL initializations from `device_operations`
Unmentioned fields are initialized with 0 (or NULL) implicitly. Beside
that, the struct has grown over the years. There are too many optional
fields to list them all.
Change-Id: Icb9e14c58153d7c14817bcde148e86e977666e4b
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40126
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/northbridge/intel/i945')
| -rw-r--r-- | src/northbridge/intel/i945/gma.c | 4 | ||||
| -rw-r--r-- | src/northbridge/intel/i945/northbridge.c | 4 |
2 files changed, 0 insertions, 8 deletions
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index f5a964ab82..252d984d2b 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -816,8 +816,6 @@ static struct device_operations gma_func0_ops = { .enable_resources = pci_dev_enable_resources, .init = gma_func0_init, .acpi_fill_ssdt = gma_generate_ssdt, - .scan_bus = 0, - .enable = 0, .disable = gma_func0_disable, .ops_pci = &gma_pci_ops, .acpi_name = gma_acpi_name, @@ -830,8 +828,6 @@ static struct device_operations gma_func1_ops = { .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = gma_func1_init, - .scan_bus = 0, - .enable = 0, .ops_pci = &gma_pci_ops, }; diff --git a/src/northbridge/intel/i945/northbridge.c b/src/northbridge/intel/i945/northbridge.c index 16cf5e6ae2..17b790740e 100644 --- a/src/northbridge/intel/i945/northbridge.c +++ b/src/northbridge/intel/i945/northbridge.c @@ -167,8 +167,6 @@ void northbridge_write_smram(u8 smram) static struct device_operations pci_domain_ops = { .read_resources = mch_domain_read_resources, .set_resources = mch_domain_set_resources, - .enable_resources = NULL, - .init = NULL, .scan_bus = pci_domain_scan_bus, .acpi_name = northbridge_acpi_name, }; @@ -196,7 +194,6 @@ static struct device_operations mc_ops = { .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .acpi_fill_ssdt = generate_cpu_entries, - .scan_bus = 0, .ops_pci = &intel_pci_ops, }; @@ -216,7 +213,6 @@ static struct device_operations cpu_bus_ops = { .set_resources = DEVICE_NOOP, .enable_resources = DEVICE_NOOP, .init = mp_cpu_bus_init, - .scan_bus = 0, }; static void enable_dev(struct device *dev) |