diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2018-07-18 16:43:43 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-01-16 16:45:26 +0000 |
| commit | a6be58fecec5e01a809ced3c87d6c24db4e2a91d (patch) | |
| tree | 1e811493bb4261c9ea7e69567245ee66a8059d51 /src/northbridge/intel/sandybridge/gma.c | |
| parent | 1ed36f9ce9d52917a04cfbe5c3b353910ca7fd1c (diff) | |
| download | coreboot-a6be58fecec5e01a809ced3c87d6c24db4e2a91d.tar.xz | |
nb/intel/sandybridge: Remove the C native graphic init
Libgfxinit provides a better alternative to the native C init. While
libgfxinit mandates an ada compiler, we want to encourage use of it
since it is in much better shape and is actually maintained.
This way libgfxinit also gets build-tested by Jenkins.
Change-Id: Ic6678d3455f1116e7e67a67b465a79df020b2399
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/27532
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/northbridge/intel/sandybridge/gma.c')
| -rw-r--r-- | src/northbridge/intel/sandybridge/gma.c | 20 |
1 files changed, 2 insertions, 18 deletions
diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index 150f78aa4f..2f797f1c30 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -635,31 +635,15 @@ static void gma_func0_init(struct device *dev) /* Running graphics init on S3 breaks Linux drm driver. */ if (!acpi_is_wakeup_s3() && - (IS_ENABLED(CONFIG_MAINBOARD_DO_NATIVE_VGA_INIT) || - IS_ENABLED(CONFIG_MAINBOARD_USE_LIBGFXINIT))) { + IS_ENABLED(CONFIG_MAINBOARD_USE_LIBGFXINIT)) { if (vga_disable) { printk(BIOS_INFO, "IGD is not decoding legacy VGA MEM and IO: skipping NATIVE graphic init\n"); } else { /* This should probably run before post VBIOS init. */ printk(BIOS_SPEW, "Initializing VGA without OPROM.\n"); - u8 *mmiobase; - u32 iobase, physbase, graphics_base; - struct northbridge_intel_sandybridge_config *conf = dev->chip_info; - iobase = dev->resource_list[2].base; - mmiobase = res2mmio(&dev->resource_list[0], 0, 0); - physbase = pci_read_config32(dev, 0x5c) & ~0xf; - graphics_base = dev->resource_list[1].base; - int lightup_ok; - if (IS_ENABLED(CONFIG_MAINBOARD_USE_LIBGFXINIT)) { - gma_gfxinit(&lightup_ok); - } else { - lightup_ok = i915lightup_sandy(&conf->gfx, - physbase, - iobase, mmiobase, - graphics_base); - } + gma_gfxinit(&lightup_ok); if (lightup_ok) gfx_set_init_done(1); } |