diff options
| author | Furquan Shaikh <furquan@google.com> | 2013-08-19 10:16:50 -0700 |
|---|---|---|
| committer | Isaac Christensen <isaac.christensen@se-eng.com> | 2014-08-13 19:32:11 +0200 |
| commit | 77f48cdeade7fc296fb5c973b6b0191ac5bd8c35 (patch) | |
| tree | d33aac05f3759fde05c29c1d43b0aaeed07c34d8 /src/northbridge/intel/sandybridge | |
| parent | 61ffb4ca2e53004d3a282bfc2c97e58131cc9ef3 (diff) | |
| download | coreboot-77f48cdeade7fc296fb5c973b6b0191ac5bd8c35.tar.xz | |
Falco/Slippy: Patch to refactor haswell/gma.c and mainboard/google/slippy/i915io.c
A large portion of documented registers have been initialized using macros. Only a few
undocumented registers are left out. i915io.c looks lot more cleaner by removing redundant
calls. However, some more work is required to correctly identify which calls are not required.
All the io_writes are replaced by gtt_writes.
Change-Id: I077a235652c7d5eb90346cd6e15cc48b5161e969
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/66204
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Commit-Queue: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
(cherry picked from commit 39f3289f68b527575b0a120960ff67f78415815e)
Signed-off-by: Isaac Christensen <isaac.christensen@se-eng.com>
Reviewed-on: http://review.coreboot.org/6600
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/northbridge/intel/sandybridge')
| -rw-r--r-- | src/northbridge/intel/sandybridge/gma.c | 2 | ||||
| -rw-r--r-- | src/northbridge/intel/sandybridge/gma.h | 2 | ||||
| -rw-r--r-- | src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index 0add055623..f305b81458 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -595,7 +595,7 @@ static void gma_func0_init(struct device *dev) physbase = pci_read_config32(dev, 0x5c) & ~0xf; graphics_base = dev->resource_list[1].base; - int lightup_ok = i915lightup(conf, physbase, iobase, mmiobase, graphics_base); + int lightup_ok = i915lightup_sandy(conf, physbase, iobase, mmiobase, graphics_base); if (lightup_ok) gfx_set_init_done(1); #endif diff --git a/src/northbridge/intel/sandybridge/gma.h b/src/northbridge/intel/sandybridge/gma.h index bc5d986e7a..b7502cda34 100644 --- a/src/northbridge/intel/sandybridge/gma.h +++ b/src/northbridge/intel/sandybridge/gma.h @@ -168,5 +168,5 @@ typedef struct { struct northbridge_intel_sandybridge_config; -int i915lightup(const struct northbridge_intel_sandybridge_config *info, +int i915lightup_sandy(const struct northbridge_intel_sandybridge_config *info, u32 physbase, u16 pio, u32 mmio, u32 lfb); diff --git a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c index ff877ffcb6..53fbfda3bc 100644 --- a/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c +++ b/src/northbridge/intel/sandybridge/gma_ivybridge_lvds.c @@ -207,7 +207,7 @@ static void enable_port(u32 mmio) read32(mmio + 0xc4000); } -int i915lightup(const struct northbridge_intel_sandybridge_config *info, +int i915lightup_sandy(const struct northbridge_intel_sandybridge_config *info, u32 physbase, u16 piobase, u32 mmio, u32 lfb) { int i; |