diff options
| author | Paul Menzel <paulepanter@users.sourceforge.net> | 2017-03-24 16:17:16 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2017-03-24 17:07:11 +0100 |
| commit | b45bbb253f106825876df77630ef7204fd25761d (patch) | |
| tree | 57b05067f8c9ec5f3c63f8651a3f7a2f905e5436 /src/northbridge/intel | |
| parent | c790850ebe81d5b9fd7018b41e2fd7bda79db8c1 (diff) | |
| download | coreboot-b45bbb253f106825876df77630ef7204fd25761d.tar.xz | |
nb/intel/i945: Fix SPD dumps
Currently the `break` further down is called unconditionally as the
brackets for the body of the if statement are missing. Add those.
Change-Id: I34917a9877dcc882d880dedea689e1d72fe52888
Found-by: Coverity (CID 1372941: Control flow issues (UNREACHABLE))
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: https://review.coreboot.org/18971
Tested-by: build bot (Jenkins)
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/northbridge/intel')
| -rw-r--r-- | src/northbridge/intel/i945/debug.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/northbridge/intel/i945/debug.c b/src/northbridge/intel/i945/debug.c index acf73c4c2d..0f388df4fb 100644 --- a/src/northbridge/intel/i945/debug.c +++ b/src/northbridge/intel/i945/debug.c @@ -87,9 +87,10 @@ void dump_spd_registers(void) if ((i % 16) == 0) printk(BIOS_DEBUG, "\n%02x: ", i); status = smbus_read_byte(device, i); - if (status < 0) + if (status < 0) { printk(BIOS_DEBUG, "bad device: %02x\n", -status); break; + } printk(BIOS_DEBUG, "%02x ", status); } device++; |