diff options
author | Uwe Hermann <uwe@hermann-uwe.de> | 2010-10-11 19:36:13 +0000 |
---|---|---|
committer | Uwe Hermann <uwe@hermann-uwe.de> | 2010-10-11 19:36:13 +0000 |
commit | 4b42a62966527f18f3894af953b0757080424b00 (patch) | |
tree | a329063d9e80bb47bfa884d15479a3e66ef0e73a /src/northbridge/via/cn400 | |
parent | aa8612ee903db447c2f59e0f084e35577fa49db4 (diff) | |
download | coreboot-4b42a62966527f18f3894af953b0757080424b00.tar.xz |
Factor out a few commonly duplicated functions from northbridge.c.
The following functions are moved to devices/device_util.c:
- ram_resource()
- tolm_test()
- find_pci_tolm()
There are only two tolm_test() / find_pci_tolm() which differ from the
defaults, one of them can easily be eliminated in a follow-up patch,
maybe even both, but for now keep it simple and only eliminate the majority.
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5937 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/northbridge/via/cn400')
-rw-r--r-- | src/northbridge/via/cn400/northbridge.c | 43 |
1 files changed, 0 insertions, 43 deletions
diff --git a/src/northbridge/via/cn400/northbridge.c b/src/northbridge/via/cn400/northbridge.c index 2fc67c925f..3982c9877c 100644 --- a/src/northbridge/via/cn400/northbridge.c +++ b/src/northbridge/via/cn400/northbridge.c @@ -161,20 +161,6 @@ static void cn400_domain_read_resources(device_t dev) printk(BIOS_SPEW, "Leaving %s.\n", __func__); } -static void ram_resource(device_t dev, unsigned long index, - unsigned long basek, unsigned long sizek) -{ - struct resource *resource; - - if (!sizek) - return; - resource = new_resource(dev, index); - resource->base = (resource_t) (basek << 10); - resource->size = (resource_t) (sizek << 10); - resource->flags = IORESOURCE_MEM | IORESOURCE_CACHEABLE | - IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED; -} - #ifdef UNUSED_CODE static void ram_reservation(device_t dev, unsigned long index, unsigned long base, unsigned long size) @@ -191,35 +177,6 @@ static void ram_reservation(device_t dev, unsigned long index, } #endif -static void tolm_test(void *gp, struct device *dev, struct resource *new) -{ - struct resource **best_p = gp; - struct resource *best; - - best = *best_p; - if (!best || (best->base > new->base)) - best = new; - *best_p = best; -} - -static u32 find_pci_tolm(struct bus *bus) -{ - struct resource *min = NULL; - u32 tolm; - - printk(BIOS_SPEW, "Entering CN400 find_pci_tolm\n"); - - search_bus_resources(bus, IORESOURCE_MEM, IORESOURCE_MEM, - tolm_test, &min); - tolm = 0xffffffffUL; - if (min && tolm > min->base) - tolm = min->base; - - printk(BIOS_SPEW, "Leaving CN400 find_pci_tolm\n"); - - return tolm; -} - #if CONFIG_WRITE_HIGH_TABLES==1 /* maximum size of high tables in KB */ #define HIGH_TABLES_SIZE 64 |