diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-10-31 08:26:21 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-11-01 21:16:40 +0100 |
| commit | d2040737a9c3e07fee5392079dea88988ad8c56c (patch) | |
| tree | c27601a1654dd66d5e7830515320147c88dfa9e7 /src/northbridge/via/cn700 | |
| parent | 812d2a47d4cdc0475dd06c14623881ca9d543c99 (diff) | |
| download | coreboot-d2040737a9c3e07fee5392079dea88988ad8c56c.tar.xz | |
northbridge/via: Use DEVICE_NOOP macro over dummy symbol
Change-Id: Ib9d0fae363c5c1fbed3a63cb8aa86716cf1f9ee1
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7289
Tested-by: build bot (Jenkins)
Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
Diffstat (limited to 'src/northbridge/via/cn700')
| -rw-r--r-- | src/northbridge/via/cn700/agp.c | 4 | ||||
| -rw-r--r-- | src/northbridge/via/cn700/cn700.h | 7 | ||||
| -rw-r--r-- | src/northbridge/via/cn700/northbridge.c | 12 |
3 files changed, 6 insertions, 17 deletions
diff --git a/src/northbridge/via/cn700/agp.c b/src/northbridge/via/cn700/agp.c index e5a0fd0905..fce61b484a 100644 --- a/src/northbridge/via/cn700/agp.c +++ b/src/northbridge/via/cn700/agp.c @@ -104,7 +104,7 @@ static void agp_init(device_t dev) } static const struct device_operations agp_operations = { - .read_resources = cn700_noop, + .read_resources = DEVICE_NOOP, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = agp_init, @@ -157,7 +157,7 @@ static void agp_bridge_init(device_t dev) } static const struct device_operations agp_bridge_operations = { - .read_resources = cn700_noop, + .read_resources = DEVICE_NOOP, .set_resources = pci_dev_set_resources, .enable_resources = pci_bus_enable_resources, .init = agp_bridge_init, diff --git a/src/northbridge/via/cn700/cn700.h b/src/northbridge/via/cn700/cn700.h index ff1d4b3ce3..3cbc3ddb98 100644 --- a/src/northbridge/via/cn700/cn700.h +++ b/src/northbridge/via/cn700/cn700.h @@ -18,13 +18,6 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#if !defined (__PRE_RAM__) -// HACK -static inline void cn700_noop(device_t dev) -{ -} -#endif - /* VGA stuff */ #define SR_INDEX 0x3c4 #define SR_DATA 0x3c5 diff --git a/src/northbridge/via/cn700/northbridge.c b/src/northbridge/via/cn700/northbridge.c index a326baf2b2..506bdd1b59 100644 --- a/src/northbridge/via/cn700/northbridge.c +++ b/src/northbridge/via/cn700/northbridge.c @@ -87,7 +87,7 @@ static void memctrl_init(device_t dev) } static const struct device_operations memctrl_operations = { - .read_resources = cn700_noop, + .read_resources = DEVICE_NOOP, .init = memctrl_init, }; @@ -161,14 +161,10 @@ static void cpu_bus_init(device_t dev) initialize_cpus(dev->link_list); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; |