Revision: linuxbios@linuxbios.org--devel/freebios--devel--2.0--patch-60

Creator:  Li-Ta Lo <ollie@lanl.gov>

More Via EPIA 

more via epia stuff, including the trival but fatal bug in auto.c


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@1978 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

2 files changed, 107 insertions, 110 deletions

diff --git a/src/northbridge/via/vt8601/northbridge.c b/src/northbridge/via/vt8601/northbridge.c
index b578a975e4..cf8e82907c 100644
--- a/src/northbridge/via/vt8601/northbridge.c
+++ b/src/northbridge/via/vt8601/northbridge.c
@@ -29,8 +29,6 @@ static void northbridge_init(device_t dev)
 	pci_write_config8(dev, 0x76, 0x52);
 }
 
-
-
 static struct device_operations northbridge_operations = {
 	.read_resources   = pci_dev_read_resources,
 	.set_resources    = pci_dev_set_resources,
@@ -46,8 +44,6 @@ static struct pci_driver northbridge_driver __pci_driver = {
 	.device = 0x0601, /* 0x8601 is the AGP bridge? */
 };
 
-
-
 #define BRIDGE_IO_MASK (IORESOURCE_IO | IORESOURCE_MEM)
 
 static void pci_domain_read_resources(device_t dev)
diff --git a/src/northbridge/via/vt8601/raminit.c b/src/northbridge/via/vt8601/raminit.c
index 71ac010156..1aa58224f7 100644
--- a/src/northbridge/via/vt8601/raminit.c
+++ b/src/northbridge/via/vt8601/raminit.c
@@ -47,32 +47,30 @@ it with the version available from LANL.
 #define DIMM_CL2 0
 #endif
 
-void dimms_read(unsigned long x) 
+void dimms_read(unsigned long x)
 {
 	uint8_t c;
-	unsigned long eax; 
+	unsigned long eax;
 	volatile unsigned long y;
-	eax =  x;
-	for(c = 0; c < 6; c++) {
-		y = * (volatile unsigned long *) eax;
+	eax = x;
+	for (c = 0; c < 6; c++) {
+		y = *(volatile unsigned long *) eax;
 		eax += 0x10000000;
 	}
 }
 
-void dimms_write(int x) 
+void dimms_write(int x)
 {
 	uint8_t c;
 	unsigned long eax = x;
-	for(c = 0; c < 6; c++) {
+	for (c = 0; c < 6; c++) {
 		*(volatile unsigned long *) eax = 0;
 		eax += 0x10000000;
 	}
 }
 
-
-
 #ifdef DEBUG_SETNORTHB
-void setnorthb(device_t north, uint8_t reg, uint8_t val) 
+void setnorthb(device_t north, uint8_t reg, uint8_t val)
 {
 	print_debug("setnorth: reg ");
 	print_debug_hex8(reg);
@@ -85,108 +83,108 @@ void setnorthb(device_t north, uint8_t reg, uint8_t val)
 #define setnorthb pci_write_config8
 #endif
 
-void
-dumpnorth(device_t north) 
+void dumpnorth(device_t north)
 {
 	unsigned int r, c;
-	for(r = 0; ; r += 16) {
+	for (r = 0;; r += 16) {
 		print_debug_hex8(r);
 		print_debug(":");
-		for(c = 0; c < 16; c++) {
-			print_debug_hex8(pci_read_config8(north, r+c));
+		for (c = 0; c < 16; c++) {
+			print_debug_hex8(pci_read_config8(north, r + c));
 			print_debug(" ");
 		}
 		print_debug("\r\n");
 		if (r >= 240)
 			break;
-  }
+	}
 }
 
-static void sdram_set_registers(const struct mem_controller *ctrl) 
+static void sdram_set_registers(const struct mem_controller *ctrl)
 {
-	device_t north = (device_t) 0;
+	device_t north = (device_t) PCI_DEV(0, 0, 0);
 	uint8_t c, r;
 
 	print_err("vt8601 init starting\r\n");
-	north = pci_locate_device(PCI_ID(0x1106, 0x8601), 0);
-	north = 0;
 	print_debug_hex32(north);
 	print_debug(" is the north\n");
 	print_debug_hex16(pci_read_config16(north, 0));
 	print_debug(" ");
 	print_debug_hex16(pci_read_config16(north, 2));
 	print_debug("\r\n");
-	
+
 	/* All we are doing now is setting initial known-good values that will
 	 * be revised later as we read SPD
-	 */	
+	 */
+
 	// memory clk enable. We are not using ECC
-	pci_write_config8(north,0x78, 0x01);
+	pci_write_config8(north, 0x78, 0x01);
 	print_debug_hex8(pci_read_config8(north, 0x78));
+
 	// dram control, see the book. 
 #if DIMM_PC133
-	pci_write_config8(north,0x68, 0x52);
+	pci_write_config8(north, 0x68, 0x52);
 #else
-	pci_write_config8(north,0x68, 0x42);
+	pci_write_config8(north, 0x68, 0x42);
 #endif
+
 	// dram control, see the book. 
-	pci_write_config8(north,0x6B, 0x0c);
+	pci_write_config8(north, 0x6B, 0x0c);
+
 	// Initial setting, 256MB in each bank, will be rewritten later.
-	pci_write_config8(north,0x5A, 0x20);
+	pci_write_config8(north, 0x5A, 0x20);
 	print_debug_hex8(pci_read_config8(north, 0x5a));
-	pci_write_config8(north,0x5B, 0x40);
-	pci_write_config8(north,0x5C, 0x60);
-	pci_write_config8(north,0x5D, 0x80);
-	pci_write_config8(north,0x5E, 0xA0);
-	pci_write_config8(north,0x5F, 0xC0);
+	pci_write_config8(north, 0x5B, 0x40);
+	pci_write_config8(north, 0x5C, 0x60);
+	pci_write_config8(north, 0x5D, 0x80);
+	pci_write_config8(north, 0x5E, 0xA0);
+	pci_write_config8(north, 0x5F, 0xC0);
 	// It seems we have to take care of these 2 registers as if 
 	// they are bank 6 and 7.
-	pci_write_config8(north,0x56, 0xC0);
-	pci_write_config8(north,0x57, 0xC0);
-	
+	pci_write_config8(north, 0x56, 0xC0);
+	pci_write_config8(north, 0x57, 0xC0);
+
 	// SDRAM in all banks
-	pci_write_config8(north,0x60, 0x3F);
+	pci_write_config8(north, 0x60, 0x3F);
+
 	// DRAM timing. I'm suspicious of this
 	// This is for all banks, 64 is 0,1.  65 is 2,3. 66 is 4,5.
 	// ras precharge 4T, RAS pulse 5T
 	// cas2 is 0xd6, cas3 is 0xe6
 	// we're also backing off write pulse width to 2T, so result is 0xee
 #if DIMM_CL2
-	pci_write_config8(north,0x64, 0xd4);
-	pci_write_config8(north,0x65, 0xd4);
-	pci_write_config8(north,0x66, 0xd4);
-#else // CL=3
-	pci_write_config8(north,0x64, 0xe4);
-	pci_write_config8(north,0x65, 0xe4);
-	pci_write_config8(north,0x66, 0xe4);
+	pci_write_config8(north, 0x64, 0xd4);
+	pci_write_config8(north, 0x65, 0xd4);
+	pci_write_config8(north, 0x66, 0xd4);
+#else				// CL=3
+	pci_write_config8(north, 0x64, 0xe4);
+	pci_write_config8(north, 0x65, 0xe4);
+	pci_write_config8(north, 0x66, 0xe4);
 #endif
 
 	// dram frequency select.
 	// enable 4K pages for 64M dram. 
 #if DIMM_PC133
-	pci_write_config8(north,0x69, 0x3c);
+	pci_write_config8(north, 0x69, 0x3c);
 #else
-	pci_write_config8(north,0x69, 0xac);
+	pci_write_config8(north, 0x69, 0xac);
 #endif
 
 	/* IMPORTANT -- disable refresh counter */
 	// refresh counter, disabled.
-	pci_write_config8(north,0x6A, 0x00);
-	
+	pci_write_config8(north, 0x6A, 0x00);
 
 	// clkenable configuration. kevinh FIXME - add precharge
-	pci_write_config8(north,0x6C, 0x00);
+	pci_write_config8(north, 0x6C, 0x00);
 	// dram read latch delay of 1 ns, MD drive 8 mA,
-	// high drive strength on MA[2:	13], we#, cas#, ras#
+	// high drive strength on MA[2: 13], we#, cas#, ras#
 	// As per Cindy Lee, set to 0x37, not 0x57
-	pci_write_config8(north,0x6D, 0x7f);
+	pci_write_config8(north, 0x6D, 0x7f);
 }
 
 /* slot is the dram slot. Return size of side0 in lower 16-bit,
  * side1 in upper 16-bit, in units of 8MB */
-static unsigned long 
-spd_module_size(unsigned char slot) 
-{ 
+static unsigned long spd_module_size(unsigned char slot)
+{
 	/* for all the DRAMS, see if they are there and get the size of each
 	 * module. This is just a very early first cut at sizing.
 	 */
@@ -195,21 +193,24 @@ spd_module_size(unsigned char slot)
 	unsigned int value = 0;
 	/* unsigned int module = ((0x50 + slot) << 1) + 1; */
 	unsigned int module = 0x50 + slot;
+
 	/* is the module there? if byte 2 is not 4, then we'll assume it 
 	 * is useless. 
 	 */
-	print_info("Slot "); 
-	print_info_hex8(slot); 
+	print_info("Slot ");
+	print_info_hex8(slot);
 	if (smbus_read_byte(module, 2) != 4) {
 		print_info(" is empty\r\n");
 		return 0;
 	}
 	print_info(" is SDRAM ");
-	
+
 	banks = smbus_read_byte(module, 17);
+
 	/* we're going to assume symmetric banks. Sorry. */
-	cols = smbus_read_byte(module, 4)  & 0xf;
-	rows = smbus_read_byte(module, 3)  & 0xf;
+	cols = smbus_read_byte(module, 4) & 0xf;
+	rows = smbus_read_byte(module, 3) & 0xf;
+
 	/* grand total. You have rows+cols addressing, * times of banks, times
 	 * width of data in bytes */
 	/* Width is assumed to be 64 bits == 8 bytes */
@@ -229,10 +230,8 @@ spd_module_size(unsigned char slot)
 
 }
 
-static int
-spd_num_chips(unsigned char slot) 
-{ 
-/*	unsigned int module = ((0x50 + slot) << 1) + 1; */
+static int spd_num_chips(unsigned char slot)
+{
 	unsigned int module = 0x50 + slot;
 	unsigned int width;
 
@@ -249,20 +248,21 @@ static void sdram_set_spd_registers(const struct mem_controller *ctrl)
 	unsigned char timing = 0xe4;
 	/* read Trp */
 	val = smbus_read_byte(0x50, 27);
-	if (val < 2*T133)
+	if (val < 2 * T133)
 		Trp = 1;
 	val = smbus_read_byte(0x50, 30);
-	if (val < 5*T133)
+	if (val < 5 * T133)
 		Tras = 0;
 	val = smbus_read_byte(0x50, 18);
 	if (val < 8)
 		casl = 1;
 	if (val < 4)
 		casl = 0;
-	
+
 	val = (Trp << 7) | (Tras << 6) | (casl << 4) | 4;
-	
-	print_debug_hex8(val); print_debug(" is the computed timing\n");
+
+	print_debug_hex8(val);
+	print_debug(" is the computed timing\n");
 	/* don't set it. Experience shows that this screwy chipset should just
 	 * be run with the most conservative timing.
 	 * pci_write_config8(0, 0x64, val);
@@ -271,23 +271,23 @@ static void sdram_set_spd_registers(const struct mem_controller *ctrl)
 
 static void set_ma_mapping(device_t north, int slot, int type)
 {
-    unsigned char reg, val;
-    int shift;
-
-    reg = 0x58 + slot/2;
-    if (slot%2 >= 1)
-        shift = 0;
-    else
-        shift = 4;
-
-    val = pci_read_config8(north, reg);
-    val &= ~(0xf << shift);
-    val |= type << shift;
-    pci_write_config8(north, reg, val);
+	unsigned char reg, val;
+	int shift;
+
+	reg = 0x58 + slot / 2;
+	if (slot % 2 >= 1)
+		shift = 0;
+	else
+		shift = 4;
+
+	val = pci_read_config8(north, reg);
+	val &= ~(0xf << shift);
+	val |= type << shift;
+	pci_write_config8(north, reg, val);
 }
 
 
-static void sdram_enable(int controllers, const struct mem_controller *ctrl) 
+static void sdram_enable(int controllers, const struct mem_controller *ctrl)
 {
 	unsigned char i;
 	static const uint8_t ramregs[] = {
@@ -295,29 +295,30 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
 	};
 	device_t north = 0;
 	uint32_t size, base, slot, ma;
-	/* begin to initialize*/
+	/* begin to initialize */
+
 	// I forget why we need this, but we do
 	dimms_write(0xa55a5aa5);
-	
-	/* set NOP*/
-	pci_write_config8(north,0x6C, 0x01);
+
+	/* set NOP */
+	pci_write_config8(north, 0x6C, 0x01);
 	print_debug("NOP\r\n");
-	/* wait 200us*/
+	/* wait 200us */
 	// You need to do the memory reference. That causes the nop cycle. 
 	dimms_read(0);
 	udelay(400);
 	print_debug("PRECHARGE\r\n");
 	/* set precharge */
-	pci_write_config8(north,0x6C, 0x02);
+	pci_write_config8(north, 0x6C, 0x02);
 	print_debug("DUMMY READS\r\n");
-	/* dummy reads*/
+	/* dummy reads */
 	dimms_read(0);
 	udelay(200);
 	print_debug("CBR\r\n");
-	/* set CBR*/
-	pci_write_config8(north,0x6C, 0x04);
-	
-	/* do 8 reads and wait >100us between each - from via*/
+	/* set CBR */
+	pci_write_config8(north, 0x6C, 0x04);
+
+	/* do 8 reads and wait >100us between each - from via */
 	dimms_read(0);
 	udelay(200);
 	dimms_read(0);
@@ -335,43 +336,43 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
 	dimms_read(0);
 	udelay(200);
 	print_debug("MRS\r\n");
-	/* set MRS*/
-	pci_write_config8(north,0x6c, 0x03);
+	/* set MRS */
+	pci_write_config8(north, 0x6c, 0x03);
 #if DIMM_CL2
 	dimms_read(0x150);
-#else // CL=3
+#else				// CL=3
 	dimms_read(0x1d0);
 #endif
 	udelay(200);
 	print_debug("NORMAL\r\n");
 	/* set to normal mode */
-	pci_write_config8(north,0x6C, 0x08);
-	
+	pci_write_config8(north, 0x6C, 0x08);
+
 	dimms_write(0x55aa55aa);
 	dimms_read(0);
 	udelay(200);
 	print_debug("set ref. rate\r\n");
 	// Set the refresh rate. 
 #if DIMM_PC133
-	pci_write_config8(north,0x6A, 0x86);
+	pci_write_config8(north, 0x6A, 0x86);
 #else
-	pci_write_config8(north,0x6A, 0x65);
+	pci_write_config8(north, 0x6A, 0x65);
 #endif
 	print_debug("enable multi-page open\r\n");
 	// enable multi-page open
-	pci_write_config8(north,0x6B, 0x0d);
-	
+	pci_write_config8(north, 0x6B, 0x0d);
+
 	base = 0;
-	for(slot = 0; slot < 4; slot++) {
+	for (slot = 0; slot < 4; slot++) {
 		size = spd_module_size(slot);
 		/* side 0 */
 		base += size & 0xffff;
-		pci_write_config8(north, ramregs[2*slot], base);
+		pci_write_config8(north, ramregs[2 * slot], base);
 		/* side 1 */
 		base += size >> 16;
 		if (base > 0xff)
 			base = 0xff;
-		pci_write_config8(north, ramregs[2*slot + 1], base);
+		pci_write_config8(north, ramregs[2 * slot + 1], base);
 
 		if (!size)
 			continue;
@@ -379,13 +380,13 @@ static void sdram_enable(int controllers, const struct mem_controller *ctrl)
 		/* Calculate the value of MA mapping type register,
 		 * based on size of SDRAM chips. */
 		size = (size & 0xffff) << (3 + 3);
-			/* convert module size to be in Mbits */
+		/* convert module size to be in Mbits */
 		size /= spd_num_chips(slot);
 		print_debug_hex16(size);
 		print_debug(" is the chip size\r\n");
 		if (size < 64)
 			ma = 0;
-		if (size < 256)
+		else if (size < 256)
 			ma = 8;
 		else
 			ma = 0xe;