summaryrefslogtreecommitdiff
path: root/src/northbridge
diff options
context:
space:
mode:
authorZheng Bao <zheng.bao@amd.com>2010-12-02 01:50:38 +0000
committerZheng Bao <Zheng.Bao@amd.com>2010-12-02 01:50:38 +0000
commitea62e9b47db50cf3cd1551525693eddb2617bd7a (patch)
treece712f506b984f9710e651ef4d0b45cc57fec27a /src/northbridge
parent9c9ae3ae8fe7ae00e6826976fb4849f8e3857db3 (diff)
downloadcoreboot-ea62e9b47db50cf3cd1551525693eddb2617bd7a.tar.xz
More explicite and straight way to set seed.
The read-modify-write wasn't needed. This is easier to understand. Signed-off-by: Zheng Bao <zheng.bao@amd.com> Acked-by: Marc Jones <marcj303@gmail.com> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6136 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/northbridge')
-rw-r--r--src/northbridge/amd/amdmct/mct/mctsrc.c8
-rw-r--r--src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c8
2 files changed, 4 insertions, 12 deletions
diff --git a/src/northbridge/amd/amdmct/mct/mctsrc.c b/src/northbridge/amd/amdmct/mct/mctsrc.c
index 258be0468d..6a0ae306b3 100644
--- a/src/northbridge/amd/amdmct/mct/mctsrc.c
+++ b/src/northbridge/amd/amdmct/mct/mctsrc.c
@@ -1023,13 +1023,9 @@ static void fenceDynTraining_D(struct MCTStatStruc *pMCTstat,
dev = pDCTstat->dev_dct;
for (index = 0x50; index <= 0x52; index ++) {
- val = Get_NB32_index_wait(dev, index_reg, index);
- val |= (FenceTrnFinDlySeed & 0x1F);
+ val = (FenceTrnFinDlySeed & 0x1F);
if (index != 0x52) {
- val &= ~(0xFF << 8);
- val |= (val & 0xFF) << 8;
- val &= 0xFFFF;
- val |= val << 16;
+ val |= val << 8 | val << 16 | val << 24;
}
Set_NB32_index_wait(dev, index_reg, index, val);
}
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c b/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
index b11da61156..76ddb88d53 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
@@ -972,13 +972,9 @@ static void fenceDynTraining_D(struct MCTStatStruc *pMCTstat,
*/
dev = pDCTstat->dev_dct;
for (index = 0x50; index <= 0x52; index ++) {
- val = Get_NB32_index_wait(dev, index_reg, index) & ~0xFF;
- val |= (FenceTrnFinDlySeed & 0x1F);
+ val = (FenceTrnFinDlySeed & 0x1F);
if (index != 0x52) {
- val &= ~(0xFF << 8);
- val |= (val & 0xFF) << 8;
- val &= 0xFFFF;
- val |= val << 16;
+ val |= val << 8 | val << 16 | val << 24;
}
Set_NB32_index_wait(dev, index_reg, index, val);
}