diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2021-03-26 23:23:22 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2021-04-10 16:03:00 +0000 |
| commit | 70dc0a8cc34dfa66473d00fc7fffdc71d38b4347 (patch) | |
| tree | a257098da6ea224a44fc53d364a76e42274bec3d /src/northbridge | |
| parent | e82191451c7a66500ac81f981042c8f166849b40 (diff) | |
| download | coreboot-70dc0a8cc34dfa66473d00fc7fffdc71d38b4347.tar.xz | |
nb/intel/x4x/dq_dqs.c: Avoid breaking strings over multiple lines
Breaking strings across multiple lines hurts greppability. Refactor the
code a bit to drop one indentation level, and then reflow the strings.
Change-Id: I0accdfd0d2c5f58e4da493ba0d4b5c6a067d92c3
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51876
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/intel/x4x/dq_dqs.c | 28 |
1 files changed, 11 insertions, 17 deletions
diff --git a/src/northbridge/intel/x4x/dq_dqs.c b/src/northbridge/intel/x4x/dq_dqs.c index afb77424af..6045f3bf41 100644 --- a/src/northbridge/intel/x4x/dq_dqs.c +++ b/src/northbridge/intel/x4x/dq_dqs.c @@ -656,16 +656,13 @@ static enum cb_err increment_to_dqs_edge(struct sysinfo *s, u8 channel, u8 rank) lane, dq_sample[lane]); - if (dq_sample[lane] > 0) { - if (decrement_dq_dqs(s, &dqs_setting[lane])) { - printk(BIOS_EMERG, - "DQS setting channel%d, " - "lane %d reached a minimum!\n", - channel, lane); - return CB_ERR; - } - } else { + if (dq_sample[lane] == 0) { bytelane_ok |= (1 << lane); + } else if (decrement_dq_dqs(s, &dqs_setting[lane])) { + printk(BIOS_EMERG, + "DQS setting channel%d, lane %d reached a minimum!\n", + channel, lane); + return CB_ERR; } dqsset(channel, lane, &dqs_setting[lane]); } @@ -695,14 +692,11 @@ static enum cb_err increment_to_dqs_edge(struct sysinfo *s, u8 channel, u8 rank) if (dq_sample[lane] == N_SAMPLES) { bytelane_ok |= (1 << lane); - } else { - if (increment_dq_dqs(s, &dqs_setting[lane])) { - printk(BIOS_EMERG, - "DQS setting channel%d, " - "lane %d reached a maximum!\n", - channel, lane); - return CB_ERR; - } + } else if (increment_dq_dqs(s, &dqs_setting[lane])) { + printk(BIOS_EMERG, + "DQS setting channel%d, lane %d reached a maximum!\n", + channel, lane); + return CB_ERR; } dqsset(channel, lane, &dqs_setting[lane]); } |