diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2013-11-23 19:22:53 -0600 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-12-02 22:11:20 +0100 |
| commit | 72dccce0c9a7cf59ca51a3174fc11eb8899e1761 (patch) | |
| tree | 0201395e975f173ebc8badcc952598d559e8a745 /src/northbridge | |
| parent | bcfcfa4473357eb6272bc8bcc5e03f4ba517bcd2 (diff) | |
| download | coreboot-72dccce0c9a7cf59ca51a3174fc11eb8899e1761.tar.xz | |
global: Fix usage of get_option() to make use of CB_CMOS_ codes
Do not directly check the return value of get_option, but instead compare
the returned value against a CB_CMOS_ error code, or against CB_SUCCESS.
Change-Id: I2fa7761d13ebb5e9b4606076991a43f18ae370ad
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/4266
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/amd/amdk8/misc_control.c | 4 | ||||
| -rw-r--r-- | src/northbridge/intel/i945/gma.c | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/northbridge/amd/amdk8/misc_control.c b/src/northbridge/amd/amdk8/misc_control.c index 030c9928c5..cab56c2f4e 100644 --- a/src/northbridge/amd/amdk8/misc_control.c +++ b/src/northbridge/amd/amdk8/misc_control.c @@ -48,10 +48,8 @@ static void mcf3_read_resources(device_t dev) } iommu = 1; - if( get_option(&iommu, "iommu") < 0 ) - { + if (get_option(&iommu, "iommu") != CB_SUCCESS) iommu = CONFIG_IOMMU; - } if (iommu) { /* Add a GART aperture resource */ diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index deda2fa128..433152c26d 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -94,7 +94,7 @@ static void gma_func1_init(struct device *dev) pci_write_config32(dev, PCI_COMMAND, reg32 | PCI_COMMAND_MASTER | PCI_COMMAND_IO); - if (!get_option(&val, "tft_brightness")) + if (get_option(&val, "tft_brightness") == CB_SUCCESS) pci_write_config8(dev, 0xf4, val); else pci_write_config8(dev, 0xf4, 0xff); |