summaryrefslogtreecommitdiff
path: root/src/northbridge
diff options
context:
space:
mode:
authorRaul E Rangel <rrangel@chromium.org>2020-05-04 16:41:22 -0600
committerPatrick Georgi <pgeorgi@google.com>2020-05-12 20:07:25 +0000
commit5cb34e2ea0034f3d3781006234a0c8b66f4efcfe (patch)
tree6a06c0cef8e1d2a4367eec3bcf6451f8e10609db /src/northbridge
parent194695fd953a2a8bd10eedc9aa7811c338988d3d (diff)
downloadcoreboot-5cb34e2ea0034f3d3781006234a0c8b66f4efcfe.tar.xz
device/pci_device: Extract pci_domain_set_resources from SOC
pci_domain_set_resources is duplicated in all the SOCs. This change promotes the duplicated function. Picasso was adding it again in the northbridge patch. I decided to promote the function instead of duplicating it. BUG=b:147042464 TEST=Build and boot trembyle. Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: Iba9661ac2c3a1803783d5aa32404143c9144aea5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41041 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/northbridge')
-rw-r--r--src/northbridge/intel/haswell/northbridge.c5
-rw-r--r--src/northbridge/intel/ironlake/northbridge.c5
-rw-r--r--src/northbridge/intel/sandybridge/northbridge.c4
3 files changed, 2 insertions, 12 deletions
diff --git a/src/northbridge/intel/haswell/northbridge.c b/src/northbridge/intel/haswell/northbridge.c
index 458439ef32..a728e0e8cf 100644
--- a/src/northbridge/intel/haswell/northbridge.c
+++ b/src/northbridge/intel/haswell/northbridge.c
@@ -52,11 +52,6 @@ static int get_pcie_bar(struct device *dev, unsigned int index, u32 *base, u32 *
return 0;
}
-static void pci_domain_set_resources(struct device *dev)
-{
- assign_resources(dev->link_list);
-}
-
static const char *northbridge_acpi_name(const struct device *dev)
{
if (dev->path.type == DEVICE_PATH_DOMAIN)
diff --git a/src/northbridge/intel/ironlake/northbridge.c b/src/northbridge/intel/ironlake/northbridge.c
index 07b8f53e61..d98af9edc9 100644
--- a/src/northbridge/intel/ironlake/northbridge.c
+++ b/src/northbridge/intel/ironlake/northbridge.c
@@ -67,11 +67,6 @@ static void add_fixed_resources(struct device *dev, int index)
#endif
}
-static void pci_domain_set_resources(struct device *dev)
-{
- assign_resources(dev->link_list);
-}
-
#if CONFIG(HAVE_ACPI_TABLES)
static const char *northbridge_acpi_name(const struct device *dev)
{
diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c
index b3772189b2..7a6372c207 100644
--- a/src/northbridge/intel/sandybridge/northbridge.c
+++ b/src/northbridge/intel/sandybridge/northbridge.c
@@ -99,7 +99,7 @@ static void add_fixed_resources(struct device *dev, int index)
}
}
-static void pci_domain_set_resources(struct device *dev)
+static void pci_domain_set_resources_sandybridge(struct device *dev)
{
uint64_t tom, me_base, touud;
uint32_t tseg_base, uma_size, tolud;
@@ -243,7 +243,7 @@ static const char *northbridge_acpi_name(const struct device *dev)
*/
static struct device_operations pci_domain_ops = {
.read_resources = pci_domain_read_resources,
- .set_resources = pci_domain_set_resources,
+ .set_resources = pci_domain_set_resources_sandybridge,
.scan_bus = pci_domain_scan_bus,
.write_acpi_tables = northbridge_write_acpi_tables,
.acpi_name = northbridge_acpi_name,