diff options
| author | Patrick Rudolph <siro@das-labor.org> | 2016-11-25 16:00:01 +0100 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-04-07 19:57:15 +0200 |
| commit | 3c8cb97ea726cfc4643f75380240e253c095bc14 (patch) | |
| tree | 9b10d6f7e4631174ed87cead4dd45c8e6050cfef /src/northbridge | |
| parent | 7dee97454a7391d61080e0ff689ee207ae41dacc (diff) | |
| download | coreboot-3c8cb97ea726cfc4643f75380240e253c095bc14.tar.xz | |
nb/intel/sandybridge/raminit: Fix normalize_training
Remove cross rank/cross channel dependency.
I guess this is a mistake that could lead to instabilities.
Tested on Lenovo T430 (Intel IvyBridge).
Change-Id: I899db907cd2d2197fd81eda4c4656fb1e570c18f
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/17610
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/intel/sandybridge/raminit_common.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 8baa0f25d1..0c77004bae 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -3023,10 +3023,11 @@ int discover_timC_write(ramctr_timing *ctrl) void normalize_training(ramctr_timing * ctrl) { int channel, slotrank, lane; - int mat = 0; + int mat; FOR_ALL_CHANNELS FOR_ALL_POPULATED_RANKS { int delta; + mat = 0; FOR_ALL_LANES mat = max(ctrl->timings[channel][slotrank].lanes[lane].timA, mat); printram("normalize %d, %d, %d: mat %d\n", |