diff options
author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2012-07-18 14:38:54 +0300 |
---|---|---|
committer | Anton Kochkov <anton.kochkov@gmail.com> | 2012-08-01 11:53:27 +0200 |
commit | 5e29f00c5598942b3f57813f90fbbb73f82e969b (patch) | |
tree | 7d7e0021a6d9062a9cff60c92837cc5d9ba8fc7a /src/northbridge | |
parent | 7f189cc74eb0358149f892c32a9bfa7b831c83a3 (diff) | |
download | coreboot-5e29f00c5598942b3f57813f90fbbb73f82e969b.tar.xz |
Intel and GFXUMA: drop redundant use of lb_add_memory_range()
Use of uma_resource() in northbridge code created a memory
resource marked as reserved. Such resources are removed
from system memory in write_coreboot_table().
Change-Id: I14bfd560140d8d30ec156562f23072bfae747bde
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/1238
Tested-by: build bot (Jenkins)
Reviewed-by: Anton Kochkov <anton.kochkov@gmail.com>
Diffstat (limited to 'src/northbridge')
-rw-r--r-- | src/northbridge/intel/i82810/northbridge.c | 9 | ||||
-rw-r--r-- | src/northbridge/intel/i82830/northbridge.c | 9 | ||||
-rw-r--r-- | src/northbridge/intel/sandybridge/northbridge.c | 5 |
3 files changed, 0 insertions, 23 deletions
diff --git a/src/northbridge/intel/i82810/northbridge.c b/src/northbridge/intel/i82810/northbridge.c index f6d14e0bd2..c738de7916 100644 --- a/src/northbridge/intel/i82810/northbridge.c +++ b/src/northbridge/intel/i82810/northbridge.c @@ -62,15 +62,6 @@ static const struct pci_driver i810e_northbridge_driver __pci_driver = { .device = 0x7124, }; -int add_northbridge_resources(struct lb_memory *mem) -{ - printk(BIOS_DEBUG, "Adding IGD UMA memory area\n"); - lb_add_memory_range(mem, LB_MEM_RESERVED, - uma_memory_base, uma_memory_size); - - return 0; -} - /* Table which returns the RAM size in MB when fed the DRP[7:4] or [3:0] value. * Note that 2 is a value which the DRP should never be programmed to. * Some size values appear twice, due to single-sided vs dual-sided banks. diff --git a/src/northbridge/intel/i82830/northbridge.c b/src/northbridge/intel/i82830/northbridge.c index 649a203aca..4951c4f617 100644 --- a/src/northbridge/intel/i82830/northbridge.c +++ b/src/northbridge/intel/i82830/northbridge.c @@ -52,15 +52,6 @@ static const struct pci_driver northbridge_driver __pci_driver = { .device = 0x3575, }; -int add_northbridge_resources(struct lb_memory *mem) -{ - printk(BIOS_DEBUG, "Adding IGD UMA memory area\n"); - lb_add_memory_range(mem, LB_MEM_RESERVED, - uma_memory_base, uma_memory_size); - - return 0; -} - #if CONFIG_WRITE_HIGH_TABLES #include <cbmem.h> #endif diff --git a/src/northbridge/intel/sandybridge/northbridge.c b/src/northbridge/intel/sandybridge/northbridge.c index 2d948eaaef..b447d52dab 100644 --- a/src/northbridge/intel/sandybridge/northbridge.c +++ b/src/northbridge/intel/sandybridge/northbridge.c @@ -61,11 +61,6 @@ int bridge_silicon_revision(void) static const int legacy_hole_base_k = 0xa0000 / 1024; static const int legacy_hole_size_k = 384; -int add_northbridge_resources(struct lb_memory *mem) -{ - return 0; -} - void cbmem_post_handling(void) { update_mrc_cache(); |