diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-07-18 00:57:37 +0300 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-08-16 22:06:51 +0000 |
| commit | 111926a1664769ab7596f2027ac041c56b5bae35 (patch) | |
| tree | c9fb3d5922f74307f0078daed2466500a1ccfe54 /src/northbridge | |
| parent | cd7578030b77fd7f2957338285c76f8cbe0b0422 (diff) | |
| download | coreboot-111926a1664769ab7596f2027ac041c56b5bae35.tar.xz | |
AGESA: Cleanup ACPI S3 support
Due to low-memory corruptions S3 support has now been
(at least temporarily) removed from AGESA platfroms.
Should we bring it back one day, CAR teardown on S3 path
will happen with an empty stack so ugly backup/recovery
of the stack will no longer be used.
If S3 feature is brought back, resume path code for FCH
will also see partial rewrite and agesawrapper.c file
will not be part of that.
Change-Id: Ib38c04d0e74f600e0b719940d5e2530f4c726cfd
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/20899
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/northbridge')
| -rw-r--r-- | src/northbridge/amd/agesa/family15tn/state_machine.c | 5 | ||||
| -rw-r--r-- | src/northbridge/amd/agesa/family16kb/state_machine.c | 5 | ||||
| -rw-r--r-- | src/northbridge/amd/agesa/state_machine.h | 4 |
3 files changed, 0 insertions, 14 deletions
diff --git a/src/northbridge/amd/agesa/family15tn/state_machine.c b/src/northbridge/amd/agesa/family15tn/state_machine.c index ad5a14ca98..8457d832d7 100644 --- a/src/northbridge/amd/agesa/family15tn/state_machine.c +++ b/src/northbridge/amd/agesa/family15tn/state_machine.c @@ -63,8 +63,6 @@ void platform_BeforeS3LateRestore(struct sysinfo *cb, AMD_S3LATE_PARAMS *S3Late) void platform_AfterS3LateRestore(struct sysinfo *cb, AMD_S3LATE_PARAMS *S3Late) { amd_initcpuio(); - - fchs3earlyrestore(); } void platform_BeforeInitMid(struct sysinfo *cb, AMD_MID_PARAMS *Mid) @@ -74,9 +72,6 @@ void platform_BeforeInitMid(struct sysinfo *cb, AMD_MID_PARAMS *Mid) void platform_AfterInitLate(struct sysinfo *cb, AMD_LATE_PARAMS *Late) { - /* FIXME: not reached S3 path */ - if (cb->s3resume) - fchs3laterestore(); } void platform_AfterS3Save(struct sysinfo *cb, AMD_S3SAVE_PARAMS *S3Save) diff --git a/src/northbridge/amd/agesa/family16kb/state_machine.c b/src/northbridge/amd/agesa/family16kb/state_machine.c index ad5a14ca98..8457d832d7 100644 --- a/src/northbridge/amd/agesa/family16kb/state_machine.c +++ b/src/northbridge/amd/agesa/family16kb/state_machine.c @@ -63,8 +63,6 @@ void platform_BeforeS3LateRestore(struct sysinfo *cb, AMD_S3LATE_PARAMS *S3Late) void platform_AfterS3LateRestore(struct sysinfo *cb, AMD_S3LATE_PARAMS *S3Late) { amd_initcpuio(); - - fchs3earlyrestore(); } void platform_BeforeInitMid(struct sysinfo *cb, AMD_MID_PARAMS *Mid) @@ -74,9 +72,6 @@ void platform_BeforeInitMid(struct sysinfo *cb, AMD_MID_PARAMS *Mid) void platform_AfterInitLate(struct sysinfo *cb, AMD_LATE_PARAMS *Late) { - /* FIXME: not reached S3 path */ - if (cb->s3resume) - fchs3laterestore(); } void platform_AfterS3Save(struct sysinfo *cb, AMD_S3SAVE_PARAMS *S3Save) diff --git a/src/northbridge/amd/agesa/state_machine.h b/src/northbridge/amd/agesa/state_machine.h index f6e94ef265..3d8e53d3d4 100644 --- a/src/northbridge/amd/agesa/state_machine.h +++ b/src/northbridge/amd/agesa/state_machine.h @@ -38,10 +38,6 @@ AGESA_STATUS OemS3LateRestore(AMD_S3_PARAMS *dataBlock); AGESA_STATUS OemS3Save(AMD_S3_PARAMS *dataBlock); #endif -/* For FCH */ -static inline void fchs3earlyrestore(void) { } -static inline void fchs3laterestore(void) { } - struct sysinfo { AMD_CONFIG_PARAMS StdHeader; |