summaryrefslogtreecommitdiff
path: root/src/northbridge
diff options
context:
space:
mode:
authorElyes HAOUAS <ehaouas@noos.fr>2019-05-20 18:39:27 +0200
committerPatrick Georgi <pgeorgi@google.com>2019-05-23 08:56:30 +0000
commit0c89c1c05e514c8c6ddc5a844f84a2b422f1bd56 (patch)
treeef26d9ab58d0a27db4d12e6f24fa25f9676716b0 /src/northbridge
parentce83f3103c9b7d0e6daa6b95544d880660d0b6e9 (diff)
downloadcoreboot-0c89c1c05e514c8c6ddc5a844f84a2b422f1bd56.tar.xz
nb/intel/x4x/early_init.c: Remove variable set but not used
Change-Id: I8d0ab8bdc506592ef1d731e557b2397481aed725 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32896 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/northbridge')
-rw-r--r--src/northbridge/intel/x4x/early_init.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/src/northbridge/intel/x4x/early_init.c b/src/northbridge/intel/x4x/early_init.c
index d019ffd7f5..a58f2ba6e9 100644
--- a/src/northbridge/intel/x4x/early_init.c
+++ b/src/northbridge/intel/x4x/early_init.c
@@ -150,7 +150,6 @@ static void init_egress(void)
static void init_dmi(void)
{
u32 reg32;
- u16 reg16;
/* Assume IGD present */
@@ -224,9 +223,11 @@ static void init_dmi(void)
/* ASPM on DMI link */
RCBA16(0x1a8) &= ~0x3;
- reg16 = RCBA16(0x1a8);
+ /* FIXME: Do we need to read RCBA16(0x1a8)? */
+ RCBA16(0x1a8);
RCBA32(0x2010) = (RCBA32(0x2010) & ~(0x3 << 10)) | (1 << 10);
- reg32 = RCBA32(0x2010);
+ /* FIXME: Do we need to read RCBA32(0x2010)? */
+ RCBA32(0x2010);
/* Set up VC1 max time */
RCBA32(0x1c) = (RCBA32(0x1c) & ~0x7f0000) | 0x120000;
@@ -240,7 +241,8 @@ static void init_dmi(void)
DMIBAR16(0x210) = (DMIBAR16(0x210) & ~(0xff7)) | 0x101;
DMIBAR32(0x88) &= ~0x3;
DMIBAR32(0x88) |= 0x3;
- reg16 = DMIBAR16(0x88);
+ /* FIXME: Do we need to read RCBA16(0x88)? */
+ DMIBAR16(0x88);
}
static void x4x_prepare_resume(int s3resume)