summaryrefslogtreecommitdiff
path: root/src/security
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2018-12-25 04:43:21 -0600
committerPatrick Georgi <pgeorgi@google.com>2018-12-28 12:24:52 +0000
commit680ed1f632897b3ec493156863b05115f28102ef (patch)
treea85ae587141e44914078500343e1f40ed2bd263c /src/security
parent337afb05676e4079263d289b21ff822570e90d3d (diff)
downloadcoreboot-680ed1f632897b3ec493156863b05115f28102ef.tar.xz
ec/chromeec: fix LPC read/write for MEC devices
Commit 8cf8aa2 [ec/google/chromeec: Use common MEC interface] changed the return mechanism for the checksum on reads/writes for MEC devices, but incorrectly handled the passed-in csum parameter by not dereferencing. This led to the returned csum value always being zero, which causes all EC commands with non- NULL data_in to fail with a checksum error. Fix this by storing the returned checksum in a temp variable, and only assigning to csum when the pointer isn't NULL; Test: build/boot google/chell, verify EC hello command succeeds, keyboard backlight turned on at boot. Change-Id: I7122c3fdc5a19f87f12975ee448728cf29948436 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/c/30444 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/security')
0 files changed, 0 insertions, 0 deletions