summaryrefslogtreecommitdiff
path: root/src/soc/amd/common
diff options
context:
space:
mode:
authorPatrick Rudolph <siro@das-labor.org>2019-11-12 16:30:14 +0100
committerPatrick Georgi <pgeorgi@google.com>2020-06-22 11:52:49 +0000
commitfc57d6c4c2848726be1361f6dee3c33e7551b857 (patch)
tree123d06ba53ecde7fcb836938cecb9eb0a199c922 /src/soc/amd/common
parent6f1d35e72dcc0d2ded8c5ebe15d8d9cf9c9ba5cb (diff)
downloadcoreboot-fc57d6c4c2848726be1361f6dee3c33e7551b857.tar.xz
cpu/x86/lapic: Support x86_64 and clean up code
Most LAPIC registers are 32bit, and thus the use of long is valid on x86_32, however it doesn't work on x86_64. * Don't use long as it is 64bit on x86_64, which breaks interrupts in QEMU and thus SeaBIOS wouldn't time out the boot menu * Get rid of unused defines * Get rid of unused atomic xchg code Tested on QEMU Q35 with x86_64 enabled: Interrupts work again. Tested on QEMU Q35 with x86_32 enabled: Interrupts are still working. Tested on Lenovo T410 with x86_64 enabled. Change-Id: Iaed1ad956d090625c7bb5cd9cf55cbae16dd82bd Signed-off-by: Patrick Rudolph <siro@das-labor.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36777 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd/common')
-rw-r--r--src/soc/amd/common/block/pi/def_callouts.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/amd/common/block/pi/def_callouts.c b/src/soc/amd/common/block/pi/def_callouts.c
index 7126c97563..56ce995f1c 100644
--- a/src/soc/amd/common/block/pi/def_callouts.c
+++ b/src/soc/amd/common/block/pi/def_callouts.c
@@ -195,7 +195,7 @@ static void callout_ap_entry(void *unused)
Status = amd_late_run_ap_task(agesadata.ConfigPtr);
if (Status)
- printk(BIOS_DEBUG, "There was a problem with %lx returned %s\n",
+ printk(BIOS_DEBUG, "There was a problem with %x returned %s\n",
lapicid(), decodeAGESA_STATUS(Status));
}