summaryrefslogtreecommitdiff
path: root/src/soc/amd/picasso/Kconfig
diff options
context:
space:
mode:
authorRob Barnes <robbarnes@google.com>2020-01-30 10:54:28 -0700
committerFelix Held <felix-coreboot@felixheld.de>2020-09-17 12:35:56 +0000
commit28cb14bf133f63f9451610348f9a84370c4b3c59 (patch)
tree69e74d71272944100a0e5e3ad1ac87d7f053210e /src/soc/amd/picasso/Kconfig
parent60795784b7ecca79572c86715b6dfd6d41ae2055 (diff)
downloadcoreboot-28cb14bf133f63f9451610348f9a84370c4b3c59.tar.xz
soc/amd/picasso: Clean up legacy UART config
Clean up configuration of the legacy UART and add Kconfig options for the mapping between UART and legacy I/O decode. BUG=b:143283592 BUG=b:153675918 TEST=Linux detects an additional legacy serial port for each active MMIO one if PICASSO_UART_LEGACY is selected. BRANCH=zork Signed-off-by: Rob Barnes <robbarnes@google.com> Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: Id08ff6428d4019303ebb6e44e13aba480cf1fde2 Reviewed-on: https://chromium-review.googlesource.com/2037891 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40322 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Diffstat (limited to 'src/soc/amd/picasso/Kconfig')
-rw-r--r--src/soc/amd/picasso/Kconfig8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index 29ebc6dd2b..3b12089bf9 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -308,12 +308,10 @@ endchoice
config PICASSO_UART_LEGACY
bool "Decode legacy I/O range"
- depends on PICASSO_CONSOLE_UART # TODO: shouldn't depend on this
help
- Assign I/O 3F8, 2F8, etc. to a Picasso UART. Only a single UART may
- decode legacy addresses and this option enables the one used for the
- console. A UART accessed with I/O does not allow all the features
- of MMIO. The MMIO decode is still present when this option is used.
+ Assign I/O 3F8, 2F8, etc. to a Picasso UART. A UART accessed with I/O
+ does not allow all the features of MMIO. The MMIO decode is still
+ present when this option is used.
config CONSOLE_UART_BASE_ADDRESS
depends on CONSOLE_SERIAL && PICASSO_CONSOLE_UART