summaryrefslogtreecommitdiff
path: root/src/soc/amd
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2020-01-28 10:56:46 -0700
committerAaron Durbin <adurbin@chromium.org>2020-01-31 17:11:17 +0000
commit5c0ef702445520e6df74f4c940163dfb8035b64b (patch)
tree948eee7488b908cc5947e068e38f45a681ec2a78 /src/soc/amd
parentdafd514d306d226e7157ac633f97f7c50923814a (diff)
downloadcoreboot-5c0ef702445520e6df74f4c940163dfb8035b64b.tar.xz
soc/amd/stoneyridge: use SMBus speed in compilation unit
The fixed bus speed of 400 kHz doesn't need to reside in a header file. Just move the assumption into the code itself. Change-Id: I426fe078909a9b725c1747380d69af31292b6d1e Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38611 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/amd')
-rw-r--r--src/soc/amd/stoneyridge/include/soc/smbus.h2
-rw-r--r--src/soc/amd/stoneyridge/southbridge.c5
2 files changed, 4 insertions, 3 deletions
diff --git a/src/soc/amd/stoneyridge/include/soc/smbus.h b/src/soc/amd/stoneyridge/include/soc/smbus.h
index 391084d807..4638fcdd83 100644
--- a/src/soc/amd/stoneyridge/include/soc/smbus.h
+++ b/src/soc/amd/stoneyridge/include/soc/smbus.h
@@ -19,8 +19,6 @@
#include <stdint.h>
#include <soc/iomap.h>
-#define SMB_SPEED_400KHZ (66000000 / (400000 * 4))
-
/*
* Between 1-10 seconds, We should never timeout normally
* Longer than this is just painful when a timeout condition occurs.
diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c
index 1b2afec3f1..b0aaf241cd 100644
--- a/src/soc/amd/stoneyridge/southbridge.c
+++ b/src/soc/amd/stoneyridge/southbridge.c
@@ -378,8 +378,11 @@ static void setup_misc(int *reboot)
static void fch_smbus_init(void)
{
+ /* 400 kHz smbus speed. */
+ const uint8_t smbus_speed = (66000000 / (400000 * 4));
+
pm_write8(SMB_ASF_IO_BASE, SMB_BASE_ADDR >> 8);
- smbus_write8(SMBTIMING, SMB_SPEED_400KHZ);
+ smbus_write8(SMBTIMING, smbus_speed);
/* Clear all SMBUS status bits */
smbus_write8(SMBHSTSTAT, SMBHST_STAT_CLEAR);
smbus_write8(SMBSLVSTAT, SMBSLV_STAT_CLEAR);