summaryrefslogtreecommitdiff
path: root/src/soc/amd
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2017-09-26 14:45:16 -0600
committerMartin Roth <martinroth@google.com>2017-10-02 16:24:49 +0000
commitf80a431c1186b8b3c79fea7a5a3ebe80f53caa0a (patch)
treeb16e8613da8acb8e0911a5c37151b37211715954 /src/soc/amd
parentda6e4f6935069789ea60332d1b58729ec83b26f2 (diff)
downloadcoreboot-f80a431c1186b8b3c79fea7a5a3ebe80f53caa0a.tar.xz
soc/amd/common: Add framework for missing AGESA callouts
These are required callout functions that currently are not implemented. agesa_LateRunApTask does not seem to be called, but the others are. BUG=b:66690176 TEST=Build Kahlee. Tested in next commit. Change-Id: Iee5f9c4847a5309a25045fca8c73be4f811c281a Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/21707 Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc/amd')
-rw-r--r--src/soc/amd/common/BiosCallOuts.h7
-rw-r--r--src/soc/amd/common/def_callouts.c43
2 files changed, 50 insertions, 0 deletions
diff --git a/src/soc/amd/common/BiosCallOuts.h b/src/soc/amd/common/BiosCallOuts.h
index c6ad585c65..c2c5556dfa 100644
--- a/src/soc/amd/common/BiosCallOuts.h
+++ b/src/soc/amd/common/BiosCallOuts.h
@@ -50,6 +50,13 @@ AGESA_STATUS agesa_GfxGetVbiosImage(UINT32 Func, UINTN FchData,
AGESA_STATUS agesa_ReadSpd(UINT32 Func, UINTN Data, VOID *ConfigPtr);
AGESA_STATUS agesa_ReadSpd_from_cbfs(UINT32 Func, UINTN Data,
VOID *ConfigPtr);
+AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr);
+AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr);
+AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data,
+ VOID *ConfigPtr);
+AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data,
+ VOID *ConfigPtr);
+AGESA_STATUS agesa_IdleAnAp(UINT32 Func, UINTN Data, VOID *ConfigPtr);
AGESA_STATUS GetBiosCallout(UINT32 Func, UINTN Data, VOID *ConfigPtr);
diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c
index fda0013d98..4b71d5b105 100644
--- a/src/soc/amd/common/def_callouts.c
+++ b/src/soc/amd/common/def_callouts.c
@@ -144,3 +144,46 @@ AGESA_STATUS agesa_ReadSpd_from_cbfs(UINT32 Func, UINTN Data, VOID *ConfigPtr)
#endif
return Status;
}
+
+AGESA_STATUS agesa_RunFcnOnAllAps(UINT32 Func, UINTN Data, VOID *ConfigPtr)
+{
+ printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+ AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+ return Status;
+}
+
+AGESA_STATUS agesa_LateRunApTask(UINT32 Func, UINTN Data, VOID *ConfigPtr)
+{
+ printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+ AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+ return Status;
+}
+
+
+AGESA_STATUS agesa_PcieSlotResetControl(UINT32 Func, UINTN Data,
+ VOID *ConfigPtr)
+{
+ printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+ AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+ return Status;
+}
+
+AGESA_STATUS agesa_WaitForAllApsFinished(UINT32 Func, UINTN Data,
+ VOID *ConfigPtr)
+{
+ printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+ AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+ return Status;
+}
+
+AGESA_STATUS agesa_IdleAnAp(UINT32 Func, UINTN Data, VOID *ConfigPtr)
+{
+ printk(BIOS_WARNING, "Warning - Missing AGESA callout: %s\n", __func__);
+ AGESA_STATUS Status = AGESA_UNSUPPORTED;
+
+ return Status;
+}