summaryrefslogtreecommitdiff
path: root/src/soc/intel/apollolake/pmc.c
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2016-10-14 10:44:23 -0500
committerAaron Durbin <adurbin@chromium.org>2016-10-16 02:49:07 +0200
commitdb52f23fbddfcfb9791389e8b8b8cfa085252ffa (patch)
tree26098b06235b49d6544d6fc600096bc95c449f74 /src/soc/intel/apollolake/pmc.c
parentc8c73a68beb199b9612c91e30ea541449957bc1a (diff)
downloadcoreboot-db52f23fbddfcfb9791389e8b8b8cfa085252ffa.tar.xz
soc/intel/apollolake: clear PMC registers
The clearing of the PMC registers was not being called resulting in state persisting across reboots. This state is queried and events are added to the eventlog like 'RTC reset' events. However, the RTC reset event is a one time thing so it should only be logged once. Without the clearing of the state the event was logged on every boot. BUG=chrome-os-partner:58496 Change-Id: I60aa7102977c2b1775ab8c54d1c147737d2af5e2 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/17027 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) Reviewed-by: Andrey Petrov <andrey.petrov@intel.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/soc/intel/apollolake/pmc.c')
-rw-r--r--src/soc/intel/apollolake/pmc.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/soc/intel/apollolake/pmc.c b/src/soc/intel/apollolake/pmc.c
index 4544e0d60d..ef39630aee 100644
--- a/src/soc/intel/apollolake/pmc.c
+++ b/src/soc/intel/apollolake/pmc.c
@@ -152,6 +152,9 @@ static void pmc_init(struct device *dev)
/* Log power state */
pch_log_state();
+
+ /* Now that things have been logged clear out the PMC state. */
+ clear_pmc_status();
}
static const struct device_operations device_ops = {