summaryrefslogtreecommitdiff
path: root/src/soc/intel/apollolake
diff options
context:
space:
mode:
authorJohn Zhao <john.zhao@intel.com>2018-10-30 15:12:11 -0700
committerPatrick Georgi <pgeorgi@google.com>2018-11-08 11:31:40 +0000
commite673e5c09eebad3efbe19d15d064d131771abc2c (patch)
tree2a2063231f69218f467e8d1ef53a3b091fe5b73a /src/soc/intel/apollolake
parente05fa66b24fa8227cb8c4e7f5a9d98871a743f98 (diff)
downloadcoreboot-e673e5c09eebad3efbe19d15d064d131771abc2c.tar.xz
soc/intel/apollolake: Improve cold boot and S3 resume
FSP 2.0.7.1 provides UPD interface to execute IPC command. Configure PmicPmcIpcCtrl for PMC to program PMIC PCH_PWROK delay from default 100ms to 10ms to improve cold boot and S3 resume performance. BUG=b:118676361 CQ-DEPEND=CL:*703187 TEST=Verified system_resume_firmware_ec time reduction. Change-Id: I05656c9083a855112120b7f1b0ec01c42f582409 Signed-off-by: John Zhao <john.zhao@intel.com> Reviewed-on: https://review.coreboot.org/29363 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
Diffstat (limited to 'src/soc/intel/apollolake')
-rw-r--r--src/soc/intel/apollolake/chip.c7
-rw-r--r--src/soc/intel/apollolake/chip.h6
2 files changed, 13 insertions, 0 deletions
diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index 9ee6dbb96d..e6904da75f 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -567,6 +567,13 @@ static void glk_fsp_silicon_init_params_cb(
* has set up. Hence skipping in FSP.
*/
silconfig->SkipSpiPCP = 1;
+
+ /*
+ * FSP provides UPD interface to execute IPC command. In order to
+ * improve boot performance, configure PmicPmcIpcCtrl for PMC to program
+ * PMIC PCH_PWROK delay.
+ */
+ silconfig->PmicPmcIpcCtrl = cfg->PmicPmcIpcCtrl;
#endif
}
diff --git a/src/soc/intel/apollolake/chip.h b/src/soc/intel/apollolake/chip.h
index 8ad622f684..202f2acf1e 100644
--- a/src/soc/intel/apollolake/chip.h
+++ b/src/soc/intel/apollolake/chip.h
@@ -156,6 +156,12 @@ struct soc_intel_apollolake_config {
* (1) Power
* (2) Power & Performance */
enum pnp_settings pnp_settings;
+
+ /* PMIC PCH_PWROK delay configuration - IPC Configuration
+ * Upd for changing PCH_PWROK delay configuration : I2C_Slave_Address
+ * (31:24) + Register_Offset (23:16) + OR Value (15:8) + AND Value (7:0)
+ */
+ uint32_t PmicPmcIpcCtrl;
};
typedef struct soc_intel_apollolake_config config_t;