diff options
author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-17 10:43:25 -0700 |
---|---|---|
committer | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-17 19:21:35 +0100 |
commit | 8a9c7dc08712e71bec5bc92bbaf93bf43126cd0d (patch) | |
tree | edfa1b727a4deab19352c7a1dddeccf672b4e4f4 /src/soc/intel/broadwell/romstage/romstage.c | |
parent | 23602dfd6812dba0499318e1ec25492faa17febb (diff) | |
download | coreboot-8a9c7dc08712e71bec5bc92bbaf93bf43126cd0d.tar.xz |
soc/intel/broadwell: Fix {}, () and conditional issues
Fix the following errors and warnings detected by checkpatch:
ERROR: open brace '{' following struct go on the same line
ERROR: return is not a function, parentheses are not required
ERROR: do not use assignment in if condition
ERROR: trailing statements should be on next line
WARNING: else is not generally useful after a break or return
WARNING: braces {} are not necessary for single statement blocks
WARNING: braces {} are not necessary for any arm of this statement
TEST=None
Change-Id: I9414341b0c778c252db33f0ef4847b9530681d96
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18884
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/soc/intel/broadwell/romstage/romstage.c')
-rw-r--r-- | src/soc/intel/broadwell/romstage/romstage.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/soc/intel/broadwell/romstage/romstage.c b/src/soc/intel/broadwell/romstage/romstage.c index 7c74aa4b8a..1a765cbf58 100644 --- a/src/soc/intel/broadwell/romstage/romstage.c +++ b/src/soc/intel/broadwell/romstage/romstage.c @@ -123,14 +123,15 @@ void asmlinkage romstage_after_car(void) { /* Load the ramstage. */ run_ramstage(); - while (1); + while (1) + ; } int get_sw_write_protect_state(void) { u8 status; /* Return unprotected status if status read fails. */ - return (early_spi_read_wpsr(&status) ? 0 : !!(status & 0x80)); + return early_spi_read_wpsr(&status) ? 0 : !!(status & 0x80); } void __attribute__((weak)) mainboard_pre_console_init(void) {} |