summaryrefslogtreecommitdiff
path: root/src/soc/intel/broadwell
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2020-12-19 23:43:56 +0200
committerKyösti Mälkki <kyosti.malkki@gmail.com>2021-02-06 07:33:51 +0000
commit0f30063abf4fa29ba6671dcbab7879334f7bd013 (patch)
treeb17043fd82103435f6ae5acf15e9924facd5d06c /src/soc/intel/broadwell
parent021c621eb0c8b21a34902519da595df94a973414 (diff)
downloadcoreboot-0f30063abf4fa29ba6671dcbab7879334f7bd013.tar.xz
soc/intel/broadwell: Conditionally skip PRE_GRAPHICS_DELAY
It was commented that the need for the delay was mainly related to external displays and only with VBIOS execution. Move the delay such that it is done only when we actually need to execute the VBIOS aka option rom. A delay is currently only defined for librem/purism_bdw in its Kconfig. As the description of the issue sounds like it would equally happen on other platforms when VBIOS is involved, promote the Kconfig visible option to global scope. Change-Id: I4503158576f35057373f003586bbf76af4d59b3d Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/48787 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/soc/intel/broadwell')
-rw-r--r--src/soc/intel/broadwell/Kconfig9
-rw-r--r--src/soc/intel/broadwell/gma.c6
2 files changed, 0 insertions, 15 deletions
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig
index 20254d5564..4b9af49a5c 100644
--- a/src/soc/intel/broadwell/Kconfig
+++ b/src/soc/intel/broadwell/Kconfig
@@ -141,15 +141,6 @@ config RO_REGION_ONLY
endif # HAVE_MRC
-config PRE_GRAPHICS_DELAY
- int "Graphics initialization delay in ms"
- default 0
- help
- On some systems, coreboot boots so fast that connected monitors
- (mostly TVs) won't be able to wake up fast enough to talk to the
- VBIOS. On those systems we need to wait for a bit before executing
- the VBIOS.
-
config INTEL_PCH_UART_CONSOLE
bool "Use Serial IO UART for console"
default n
diff --git a/src/soc/intel/broadwell/gma.c b/src/soc/intel/broadwell/gma.c
index b6ce426cde..59379b576b 100644
--- a/src/soc/intel/broadwell/gma.c
+++ b/src/soc/intel/broadwell/gma.c
@@ -513,12 +513,6 @@ static void igd_init(struct device *dev)
if (!CONFIG(NO_GFX_INIT))
pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER);
- /* Wait for any configured pre-graphics delay */
- if (!acpi_is_wakeup_s3()) {
- if (!CONFIG(CHROMEOS) || display_init_required())
- mdelay(CONFIG_PRE_GRAPHICS_DELAY);
- }
-
/* Early init steps */
if (is_broadwell) {
reg_script_run_on_dev(dev, broadwell_early_init_script);