summaryrefslogtreecommitdiff
path: root/src/soc/intel/cannonlake
diff options
context:
space:
mode:
authorMichael Niewöhner <foss@mniewoehner.de>2020-10-04 14:34:41 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-10-19 07:09:12 +0000
commit4e8baf9202a3de5dafeb1e26f95ded999ed5c667 (patch)
treefd8c458ad2c65d734b9003d3f9b18baaee26caa3 /src/soc/intel/cannonlake
parent4b6ff98e84832bbdaab002dc6d5c860ec3b37ad5 (diff)
downloadcoreboot-4e8baf9202a3de5dafeb1e26f95ded999ed5c667.tar.xz
soc/intel/*: drop useless XTAL shutdown qualification code
The XTAL shutdown (dis)qualification bit already unconditionally gets set to 1 by FSP for these platforms, making this code redundant. Change-Id: I7fa4afb0de2af1814e5b91c152d82d7ead310338 Signed-off-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/46016 Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/cannonlake')
-rw-r--r--src/soc/intel/cannonlake/finalize.c15
1 files changed, 5 insertions, 10 deletions
diff --git a/src/soc/intel/cannonlake/finalize.c b/src/soc/intel/cannonlake/finalize.c
index 9eb9cbea8c..6ef43b97f8 100644
--- a/src/soc/intel/cannonlake/finalize.c
+++ b/src/soc/intel/cannonlake/finalize.c
@@ -73,16 +73,11 @@ static void pch_finalize(void)
if (config->PmTimerDisabled)
pmc_disable_acpi_timer();
- if (config->s0ix_enable) {
- /* Disable XTAL shutdown qualification for low power idle. */
- pmc_ignore_xtal_shutdown();
-
- if (config->cppmvric2_adsposcdis) {
- /* Enable Audio DSP OSC qualification for S0ix */
- reg32 = read32(pmcbase + CPPMVRIC2);
- reg32 &= ~ADSPOSCDIS;
- write32(pmcbase + CPPMVRIC2, reg32);
- }
+ if (config->s0ix_enable && config->cppmvric2_adsposcdis) {
+ /* Enable Audio DSP OSC qualification for S0ix */
+ reg32 = read32(pmcbase + CPPMVRIC2);
+ reg32 &= ~ADSPOSCDIS;
+ write32(pmcbase + CPPMVRIC2, reg32);
}
pch_handle_sideband(config);