diff options
author | Angel Pons <th3fanbus@gmail.com> | 2020-12-05 18:28:33 +0100 |
---|---|---|
committer | Hung-Te Lin <hungte@chromium.org> | 2020-12-17 13:54:43 +0000 |
commit | d3f7028993de959d7592acd564ffacf601709e89 (patch) | |
tree | 3a5b57f9b81403717b5015cf073358e0702e77c6 /src/soc/intel/common/hda_verb.c | |
parent | d425ddd10518b38fa107d3278cc483c036445a40 (diff) | |
download | coreboot-d3f7028993de959d7592acd564ffacf601709e89.tar.xz |
azalia: Replace `hda_find_verb` uses
This function is equivalent to `azalia_find_verb` in its current form,
so replace them. Also, adapt and move the function description comment.
Change-Id: I40d1e634c31b00bd7808a651990d9bd6f0d054e9
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48351
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Diffstat (limited to 'src/soc/intel/common/hda_verb.c')
-rw-r--r-- | src/soc/intel/common/hda_verb.c | 47 |
1 files changed, 1 insertions, 46 deletions
diff --git a/src/soc/intel/common/hda_verb.c b/src/soc/intel/common/hda_verb.c index 57104c494e..e812ec5152 100644 --- a/src/soc/intel/common/hda_verb.c +++ b/src/soc/intel/common/hda_verb.c @@ -91,51 +91,6 @@ static int hda_wait_for_valid(u8 *base) return -1; } -/* - * Find a specific entry within a verb table - * - * @param verb_table_bytes: verb table size in bytes - * @param verb_table_data: verb table data - * @param viddid: vendor/device to search for - * @param verb: pointer to entry within table - * - * Returns size of the entry within the verb table, - * Returns 0 if the entry is not found - * - * The HDA verb table is composed of dwords. A set of 4 dwords is - * grouped together to form a "jack" descriptor. - * Bits 31:28 - Codec Address - * Bits 27:20 - NID - * Bits 19:8 - Verb ID - * Bits 7:0 - Payload - * - * coreboot groups different codec verb tables into a single table - * and prefixes each with a specific header consisting of 3 - * dword entries: - * 1 - Codec Vendor/Device ID - * 2 - Subsystem ID - * 3 - Number of jacks (groups of 4 dwords) for this codec - */ -static u32 hda_find_verb(u32 verb_table_bytes, - const u32 *verb_table_data, - u32 viddid, const u32 **verb) -{ - int idx = 0; - - while (idx < (verb_table_bytes / sizeof(u32))) { - u32 verb_size = 4 * verb_table_data[idx+2]; // in u32 - if (verb_table_data[idx] != viddid) { - idx += verb_size + 3; // skip verb + header - continue; - } - *verb = &verb_table_data[idx+3]; - return verb_size; - } - - /* Not all codecs need to load another verb */ - return 0; -} - int hda_codec_write(u8 *base, u32 size, const u32 *data) { int i; @@ -184,7 +139,7 @@ int hda_codec_init(u8 *base, int addr, int verb_size, const u32 *verb_data) reg32 = read32(base + HDA_IR_REG); printk(BIOS_DEBUG, "HDA: codec viddid: %08x\n", reg32); - size = hda_find_verb(verb_size, verb_data, reg32, &verb); + size = azalia_find_verb(verb_data, verb_size, reg32, &verb); if (!size) { printk(BIOS_DEBUG, "HDA: No verb table entry found\n"); return -1; |