summaryrefslogtreecommitdiff
path: root/src/soc/intel/common
diff options
context:
space:
mode:
authorSubrata Banik <subrata.banik@intel.com>2020-02-18 11:20:30 +0530
committerPatrick Georgi <pgeorgi@google.com>2020-02-19 12:11:40 +0000
commit0d866f8cd830f0ec6e84d7b284f15d2a2b485888 (patch)
treebf8eced78cfe979185d243bab0455ae6ce06abf1 /src/soc/intel/common
parentf71c6ae216bb493275a4b6a20577c883f7575ca0 (diff)
downloadcoreboot-0d866f8cd830f0ec6e84d7b284f15d2a2b485888.tar.xz
soc/intel/common/block/lpc: Drop unnecessary helper function
This patch removes unnecessary helper function pch_lpc_interrupt_init() and directly uses soc_pch_pirq_init() function to avoid redundant device NULL check. TEST=Able to build and boot CML platform. Change-Id: I3d11afb7e98f9b7f84beb2fdf308bbffeb3bbff7 Signed-off-by: Subrata Banik <subrata.banik@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/38952 Reviewed-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Nico Huber <nico.h@gmx.de> Reviewed-by: Aamir Bohra <aamir.bohra@intel.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/soc/intel/common')
-rw-r--r--src/soc/intel/common/block/lpc/lpc_lib.c13
1 files changed, 1 insertions, 12 deletions
diff --git a/src/soc/intel/common/block/lpc/lpc_lib.c b/src/soc/intel/common/block/lpc/lpc_lib.c
index 3ad2176c11..5b30a8121b 100644
--- a/src/soc/intel/common/block/lpc/lpc_lib.c
+++ b/src/soc/intel/common/block/lpc/lpc_lib.c
@@ -270,17 +270,6 @@ static void lpc_set_gen_decode_range(
gen_io_dec[i]);
}
-static void pch_lpc_interrupt_init(void)
-{
- const struct device *dev;
-
- dev = pcidev_on_root(PCH_DEV_SLOT_LPC, 0);
- if (!dev)
- return;
-
- soc_pch_pirq_init(dev);
-}
-
void pch_enable_lpc(void)
{
/* Lookup device tree in romstage */
@@ -295,7 +284,7 @@ void pch_enable_lpc(void)
lpc_set_gen_decode_range(gen_io_dec);
soc_setup_dmi_pcr_io_dec(gen_io_dec);
if (ENV_PAYLOAD_LOADER)
- pch_lpc_interrupt_init();
+ soc_pch_pirq_init(dev);
}
void lpc_enable_pci_clk_cntl(void)