summaryrefslogtreecommitdiff
path: root/src/soc/intel/denverton_ns/soc_util.c
diff options
context:
space:
mode:
authorKyösti Mälkki <kyosti.malkki@gmail.com>2019-07-03 07:25:59 +0300
committerNico Huber <nico.h@gmx.de>2019-07-04 09:48:22 +0000
commit903b40a8a46b6e8d853f509480661c8174311f17 (patch)
treefd07ccd13dd831f2a30fac410c89125ed9eae1ce /src/soc/intel/denverton_ns/soc_util.c
parent9c0e14e7c43e85e99c0bbfdff72019d908de1711 (diff)
downloadcoreboot-903b40a8a46b6e8d853f509480661c8174311f17.tar.xz
soc/intel: Replace uses of dev_find_slot()
To call dev_find_slot(0, xx) in romstage can produce invalid results since PCI bus enumeration has not been progressed yet. Replace this with method that relies on bus topology that walks the root bus only. Change-Id: I2883610059bb9fa860bba01179e7d5c58cae00e5 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/33996 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to 'src/soc/intel/denverton_ns/soc_util.c')
-rw-r--r--src/soc/intel/denverton_ns/soc_util.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/intel/denverton_ns/soc_util.c b/src/soc/intel/denverton_ns/soc_util.c
index ba7ba0f0b7..ef95f7e562 100644
--- a/src/soc/intel/denverton_ns/soc_util.c
+++ b/src/soc/intel/denverton_ns/soc_util.c
@@ -37,7 +37,7 @@ pci_devfn_t get_hostbridge_dev(void)
#else
struct device *get_hostbridge_dev(void)
{
- return dev_find_slot(0, PCI_DEVFN(SA_DEV, SA_FUNC));
+ return pcidev_on_root(SA_DEV, SA_FUNC);
}
#endif
@@ -49,7 +49,7 @@ pci_devfn_t get_lpc_dev(void)
#else
struct device *get_lpc_dev(void)
{
- return dev_find_slot(0, PCI_DEVFN(LPC_DEV, LPC_FUNC));
+ return pcidev_on_root(LPC_DEV, LPC_FUNC);
}
#endif
@@ -61,7 +61,7 @@ pci_devfn_t get_pmc_dev(void)
#else
struct device *get_pmc_dev(void)
{
- return dev_find_slot(0, PCI_DEVFN(PMC_DEV, PMC_FUNC));
+ return pcidev_on_root(PMC_DEV, PMC_FUNC);
}
#endif
@@ -73,7 +73,7 @@ pci_devfn_t get_smbus_dev(void)
#else
struct device *get_smbus_dev(void)
{
- return dev_find_slot(0, PCI_DEVFN(SMBUS_DEV, SMBUS_FUNC));
+ return pcidev_on_root(SMBUS_DEV, SMBUS_FUNC);
}
#endif