diff options
| author | Andrey Petrov <anpetrov@fb.com> | 2019-10-11 11:31:08 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-10-16 14:11:17 +0000 |
| commit | ee0b7ad683fabafef228c624348057d31fe1e6d2 (patch) | |
| tree | d7f29474b13e94f3e3f2a1745749a5725fed80f9 /src/soc/intel/fsp_broadwell_de/ubox.c | |
| parent | 89f596764775f5de53d4e17a95d2ec88c254e24a (diff) | |
| download | coreboot-ee0b7ad683fabafef228c624348057d31fe1e6d2.tar.xz | |
mainboard/ocp/monolake: Hide IIO root ports before memory init
It turned on some SKUs FSP hangs in Notify stage if IIO root ports are
disabled after MemoryInit. To address that hide IIO root ports earlier
in romstage.
TEST=the patch was ran on affected HW and success was reported
Change-Id: I6a2a405f729df14f46bcf34a24e66e8ba9415f9d
Signed-off-by: Andrey Petrov <anpetrov@fb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35968
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Diffstat (limited to 'src/soc/intel/fsp_broadwell_de/ubox.c')
| -rw-r--r-- | src/soc/intel/fsp_broadwell_de/ubox.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/soc/intel/fsp_broadwell_de/ubox.c b/src/soc/intel/fsp_broadwell_de/ubox.c index d7352ad667..e3e55e0624 100644 --- a/src/soc/intel/fsp_broadwell_de/ubox.c +++ b/src/soc/intel/fsp_broadwell_de/ubox.c @@ -18,10 +18,13 @@ #include <stdint.h> #include <soc/ubox.h> -void iio_hide(const uint8_t devno, const uint8_t funcno) +void iio_hide(DEVTREE_CONST struct device *dev) { pci_devfn_t ubox_dev; + uint8_t slot, func; + slot = PCI_SLOT(dev->path.pci.devfn); + func = PCI_FUNC(dev->path.pci.devfn); ubox_dev = PCI_DEV(get_busno1(), UBOX_DEV, UBOX_FUNC); - pci_or_config32(ubox_dev, UBOX_DEVHIDE0 + funcno * 4, 1 << devno); + pci_or_config32(ubox_dev, UBOX_DEVHIDE0 + func * 4, 1 << slot); } |