diff options
| author | Ravi Sarawadi <ravishankar.sarawadi@intel.com> | 2017-09-28 17:06:01 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2017-10-03 20:23:21 +0000 |
| commit | 1483d1fcda092283c303fd1d4f4aeca75dcd0bf1 (patch) | |
| tree | 8d7fd3948634e5a8b46aaa2655a759c00843ff9c /src/soc/intel/skylake/lockdown.c | |
| parent | a9b5a393955d2731eb20e3312b95859a55d6230d (diff) | |
| download | coreboot-1483d1fcda092283c303fd1d4f4aeca75dcd0bf1.tar.xz | |
soc/intel/skylake: Enable common LPC IP
Enable Skylake to use the new common LPC code. This
will help to reduce code duplication and streamline code bring up.
Change-Id: I042e459fb7c07f024a7f6a5fe7da13eb5f0dd688
Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi@intel.com>
Reviewed-on: https://review.coreboot.org/20120
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/soc/intel/skylake/lockdown.c')
| -rw-r--r-- | src/soc/intel/skylake/lockdown.c | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/src/soc/intel/skylake/lockdown.c b/src/soc/intel/skylake/lockdown.c index 8c34fa73ed..79f6f70987 100644 --- a/src/soc/intel/skylake/lockdown.c +++ b/src/soc/intel/skylake/lockdown.c @@ -17,8 +17,8 @@ #include <bootstate.h> #include <chip.h> #include <intelblocks/fast_spi.h> +#include <intelblocks/lpc_lib.h> #include <intelblocks/pcr.h> -#include <soc/lpc.h> #include <soc/pci_devs.h> #include <soc/pcr_ids.h> #include <soc/pm.h> @@ -29,18 +29,11 @@ static void lpc_lockdown_config(const struct soc_intel_skylake_config *config) { - struct device *dev; - uint8_t reg_mask = 0; - - dev = PCH_DEV_LPC; - /* Set Bios Interface Lock, Bios Lock */ - if (config->chipset_lockdown == CHIPSET_LOCKDOWN_COREBOOT) - reg_mask |= LPC_BC_BILD | LPC_BC_LE; - - pci_or_config8(dev, BIOS_CNTL, reg_mask); - /* Ensure an additional read back after performing lock down */ - pci_read_config8(dev, BIOS_CNTL); + if (config->chipset_lockdown == CHIPSET_LOCKDOWN_COREBOOT) { + lpc_set_bios_interface_lock_down(); + lpc_set_lock_enable(); + } } static void pmc_lockdown_config(void) |