summaryrefslogtreecommitdiff
path: root/src/soc/intel/skylake/lpc.c
diff options
context:
space:
mode:
authorNaresh G Solanki <Naresh.Solanki@intel.com>2015-12-11 18:13:02 +0530
committerPatrick Georgi <pgeorgi@google.com>2016-01-19 17:23:42 +0100
commita1b3547f0f6e08ad2c83c0224e375217bf187120 (patch)
tree9c9ae33bd9402131f01563ed3f653eb80a742757 /src/soc/intel/skylake/lpc.c
parentbdab9f787c7d608034bb2b02e68b9812f0450932 (diff)
downloadcoreboot-a1b3547f0f6e08ad2c83c0224e375217bf187120.tar.xz
intel/skylake: Fix issues found by klockwork
src/soc/intel/skylake/acpi.c Function cbmem_find may return NULL, check before using its result. src/soc/intel/skylake/flash_controller.c Remove dead code: spi_claim_bus is a no-op, always returning 0. src/soc/intel/skylake/gpio.c Check for NULL before using pointers. src/soc/intel/skylake/igd.c Don't copy 0-termination of signature string. src/soc/intel/skylake/lpc.c Don't check unsigned >= 0. src/soc/intel/skylake/systemagent.c Explicitly cast result to 64bit. BRANCH=None BUG=chrome-os-partner:48542 TEST=Built & booted Kunimitsu board. Change-Id: I6cbf4f78382383d3c8c3b15f66c5898ab5bf183a Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Original-Commit-Id: d98a8cdd3d095a6943c0e104cd4938639a62bd14 Original-Change-Id: Id2a31402618f4c9f6f53525ebcf6b71fd67428db Original-Signed-off-by: Naresh G Solanki <Naresh.Solanki@intel.com> Original-Reviewed-on: https://chromium-review.googlesource.com/317522 Original-Commit-Ready: Naresh Solanki <naresh.solanki@intel.com> Original-Tested-by: Naresh Solanki <naresh.solanki@intel.com> Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://review.coreboot.org/12991 Reviewed-by: Martin Roth <martinroth@google.com> Tested-by: build bot (Jenkins)
Diffstat (limited to 'src/soc/intel/skylake/lpc.c')
-rw-r--r--src/soc/intel/skylake/lpc.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/soc/intel/skylake/lpc.c b/src/soc/intel/skylake/lpc.c
index ff413f49ba..e47026c4f8 100644
--- a/src/soc/intel/skylake/lpc.c
+++ b/src/soc/intel/skylake/lpc.c
@@ -209,9 +209,12 @@ static inline int pch_io_range_in_default(u16 base, u16 size)
if (base >= LPC_DEFAULT_IO_RANGE_UPPER)
return 0;
- /* Is it entirely contained? */
- if (base >= LPC_DEFAULT_IO_RANGE_LOWER &&
- (base + size) < LPC_DEFAULT_IO_RANGE_UPPER)
+ /*
+ * Is it entirely contained?
+ * Since LPC_DEFAULT_IO_RANGE_LOWER is Zero,
+ * it need not be checked against lower base.
+ */
+ if ((base + size) < LPC_DEFAULT_IO_RANGE_UPPER)
return 1;
/* This will return not in range for partial overlaps. */